linux-kernel - RE: [PATCH] arm64: fix /proc/cpuinfo for elf32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <678F3D1BB717D949B966B68EAEB446ED0A6E6FB7@SZXEMA509-MBX.china.huawei.com>
Date:	Tue, 26 Apr 2016 02:21:16 +0000
From:	"Zengtao (B)" <prime.zeng@...ilicon.com>
To:	Catalin Marinas <catalin.marinas@....com>
CC:	"will.deacon@....com" <will.deacon@....com>,
	"mark.rutland@....com" <mark.rutland@....com>,
	"yang.shi@...aro.org" <yang.shi@...aro.org>,
	"suzuki.poulose@....com" <suzuki.poulose@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"james.morse@....com" <james.morse@....com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH] arm64: fix /proc/cpuinfo for elf32

> -----Original Message-----
> From: Catalin Marinas [mailto:catalin.marinas@....com]
> Sent: Monday, April 25, 2016 5:13 PM
> To: Zengtao (B)
> Cc: will.deacon@....com; mark.rutland@....com; yang.shi@...aro.org;
> suzuki.poulose@....com; linux-kernel@...r.kernel.org;
> james.morse@....com; linux-arm-kernel@...ts.infradead.org
> Subject: Re: [PATCH] arm64: fix /proc/cpuinfo for elf32
> 
> On Mon, Apr 25, 2016 at 11:37:33AM +0800, Zeng Tao wrote:
> > For elf32 thread, personality is used for arm32,
> > and thread_flag for arm64.
> >
> > Here personality is used for arm64, so fix it.
> >
> > Signed-off-by: Zeng Tao <prime.zeng@...wei.com>
> > ---
> >  arch/arm64/kernel/cpuinfo.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/kernel/cpuinfo.c b/arch/arm64/kernel/cpuinfo.c
> > index 84c8684..f739398 100644
> > --- a/arch/arm64/kernel/cpuinfo.c
> > +++ b/arch/arm64/kernel/cpuinfo.c
> > @@ -126,7 +126,7 @@ static int c_show(struct seq_file *m, void *v)
> >  		 * software which does already (at least for 32-bit).
> >  		 */
> >  		seq_puts(m, "Features\t:");
> > -		if (personality(current->personality) == PER_LINUX32) {
> > +		if (test_thread_flag(TIF_32BIT)) {
> >  #ifdef CONFIG_COMPAT
> >  			for (j = 0; compat_hwcap_str[j]; j++)
> >  				if (compat_elf_hwcap & (1 << j))
> 
> We discussed this some time ago and we decided against it. One reason
> was scripts where you may or may not end up with the desired cpuinfo
> (e.g. grep being 64-bit invoked by a 32-bit bash). The personality at
> least is inherited by child processes.

So you mean the 64-bit grep should see the same cpuinfo as its father process
which is 32-bit?

For 32-bit process running on 64-bit kernel, we have to explicitly call the personality 
syscall to get the right cpuinfo, but how to deal with the old 32-bit binaries? 
 

> 
> --
> Catalin