linux-kernel - Re: [PATCH v3 2/2] ASoC: codecs: add support for TAS5720 digital amplifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160426173743.GE2885@borg.dal.design.ti.com>
Date:	Tue, 26 Apr 2016 12:37:43 -0500
From:	Andreas Dannenberg <dannenberg@...com>
To:	"Andrew F. Davis" <afd@...com>
CC:	<alsa-devel@...a-project.org>, <devicetree@...r.kernel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/2] ASoC: codecs: add support for TAS5720 digital
 amplifier

On Tue, Apr 26, 2016 at 12:19:05PM -0500, Andrew F. Davis wrote:
> On 04/25/2016 03:17 PM, Andreas Dannenberg wrote:
> > The Texas Instruments TAS5720L/M device is a high-efficiency mono
> > Class-D audio power amplifier optimized for high transient power
> > capability to use the dynamic power headroom of small loudspeakers.
> > Its digital time division multiplexed (TDM) interface enables up to
> > 16 devices to share the same bus.
> > 
> > Signed-off-by: Andreas Dannenberg <dannenberg@...com>
> > ---
> >  sound/soc/codecs/Kconfig   |  10 +
> >  sound/soc/codecs/Makefile  |   2 +
> >  sound/soc/codecs/tas5720.c | 638 +++++++++++++++++++++++++++++++++++++++++++++
> >  sound/soc/codecs/tas5720.h |  90 +++++++
> >  4 files changed, 740 insertions(+)
> >  create mode 100644 sound/soc/codecs/tas5720.c
> >  create mode 100644 sound/soc/codecs/tas5720.h
> > 
> > diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> > index 290f921..3949dae 100644
> > --- a/sound/soc/codecs/Kconfig
> > +++ b/sound/soc/codecs/Kconfig
> > @@ -125,6 +125,7 @@ config SND_SOC_ALL_CODECS
> >  	select SND_SOC_TAS2552 if I2C
> >  	select SND_SOC_TAS5086 if I2C
> >  	select SND_SOC_TAS571X if I2C
> > +	select SND_SOC_TAS5720 if I2C
> >  	select SND_SOC_TFA9879 if I2C
> >  	select SND_SOC_TLV320AIC23_I2C if I2C
> >  	select SND_SOC_TLV320AIC23_SPI if SPI_MASTER
> > @@ -748,6 +749,15 @@ config SND_SOC_TAS571X
> >  	tristate "Texas Instruments TAS5711/TAS5717/TAS5719/TAS5721 power amplifiers"
> >  	depends on I2C
> >  
> > +config SND_SOC_TAS5720
> > +	tristate "Texas Instruments TAS5720 Mono Audio amplifier"
> > +	depends on I2C
> > +	help
> > +	  Enable support for Texas Instruments TAS5720L/M high-efficiency mono
> > +	  Class-D audio power amplifiers. The devices use an I2C interface for
> > +	  setup/control and support an optional GPIO interrupt signal for fault
> > +	  reporting.
> 
> If fault reporting is no longer interrupt based could this be re-worded?

Good catch! Thanks Andrew.

> 
> [...]
> 
> > +
> > +static struct i2c_driver tas5720_i2c_driver = {
> > +	.driver = {
> > +		.name = "tas5720",
> > +		.owner = THIS_MODULE,
> 
> This shouldn't be needed.

Yes. I recall your recent mass-optimizations. Will remove.

Regards,
Andreas