linux-kernel - Re: [PATCH 21/28] mm, page_alloc: Avoid looking up the first zone in a zonelist twice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <571FA958.6060200@suse.cz>
Date:	Tue, 26 Apr 2016 19:46:00 +0200
From:	Vlastimil Babka <vbabka@...e.cz>
To:	Mel Gorman <mgorman@...hsingularity.net>,
	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Jesper Dangaard Brouer <brouer@...hat.com>,
	Linux-MM <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 21/28] mm, page_alloc: Avoid looking up the first zone in
 a zonelist twice

On 04/15/2016 11:07 AM, Mel Gorman wrote:
> The allocator fast path looks up the first usable zone in a zonelist
> and then get_page_from_freelist does the same job in the zonelist
> iterator. This patch preserves the necessary information.
>
>                                             4.6.0-rc2                  4.6.0-rc2
>                                        fastmark-v1r20             initonce-v1r20
> Min      alloc-odr0-1               364.00 (  0.00%)           359.00 (  1.37%)
> Min      alloc-odr0-2               262.00 (  0.00%)           260.00 (  0.76%)
> Min      alloc-odr0-4               214.00 (  0.00%)           214.00 (  0.00%)
> Min      alloc-odr0-8               186.00 (  0.00%)           186.00 (  0.00%)
> Min      alloc-odr0-16              173.00 (  0.00%)           173.00 (  0.00%)
> Min      alloc-odr0-32              165.00 (  0.00%)           165.00 (  0.00%)
> Min      alloc-odr0-64              161.00 (  0.00%)           162.00 ( -0.62%)
> Min      alloc-odr0-128             159.00 (  0.00%)           161.00 ( -1.26%)
> Min      alloc-odr0-256             168.00 (  0.00%)           170.00 ( -1.19%)
> Min      alloc-odr0-512             180.00 (  0.00%)           181.00 ( -0.56%)
> Min      alloc-odr0-1024            190.00 (  0.00%)           190.00 (  0.00%)
> Min      alloc-odr0-2048            196.00 (  0.00%)           196.00 (  0.00%)
> Min      alloc-odr0-4096            202.00 (  0.00%)           202.00 (  0.00%)
> Min      alloc-odr0-8192            206.00 (  0.00%)           205.00 (  0.49%)
> Min      alloc-odr0-16384           206.00 (  0.00%)           205.00 (  0.49%)
>
> The benefit is negligible and the results are within the noise but each
> cycle counts.

Hmm this indeed doesn't look too convincing to justify the patch. Also it's 
adding adding extra pointer dereferences by accessing zone via zoneref, and the 
next patch does the same with classzone_idx (stack saving shouldn't be that 
important when the purpose of alloc_context is to have all of it only once on 
stack). I don't feel strongly enough to NAK, but not convinced to ack either.