linux-kernel - Re: [PATCH net-next] tuntap: calculate rps hash only when needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201604261034.Sv6kLC4F%fengguang.wu@intel.com>
Date:	Tue, 26 Apr 2016 10:30:24 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Jason Wang <jasowang@...hat.com>
Cc:	kbuild-all@...org, davem@...emloft.net, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, Jason Wang <jasowang@...hat.com>,
	"Michael S. Tsirkin" <mst@...hat.com>
Subject: Re: [PATCH net-next] tuntap: calculate rps hash only when needed

Hi,

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Jason-Wang/tuntap-calculate-rps-hash-only-when-needed/20160426-095825
config: xtensa-allyesconfig (attached as .config)
compiler: 
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=xtensa 

All errors (new ones prefixed by >>):

   drivers/net/tun.c: In function 'tun_net_xmit':
>> drivers/net/tun.c:836:42: error: 'rps_needed' undeclared (first use in this function)
     if (numqueues == 1 && static_key_false(&rps_needed)) {
                                             ^
   drivers/net/tun.c:836:42: note: each undeclared identifier is reported only once for each function it appears in

vim +/rps_needed +836 drivers/net/tun.c

   830		numqueues = ACCESS_ONCE(tun->numqueues);
   831	
   832		/* Drop packet if interface is not attached */
   833		if (txq >= numqueues)
   834			goto drop;
   835	
 > 836		if (numqueues == 1 && static_key_false(&rps_needed)) {
   837			/* Select queue was not called for the skbuff, so we extract the
   838			 * RPS hash and save it into the flow_table here.
   839			 */

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (44887 bytes)