linux-kernel - Re: [PATCH] block: partitions: efi: Always check for alternative GPT at end of drive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <571FC111.7020700@gmail.com>
Date:	Tue, 26 Apr 2016 15:27:13 -0400
From:	"Austin S. Hemmelgarn" <ahferroin7@...il.com>
To:	Davidlohr Bueso <dave@...olabs.net>
Cc:	Julius Werner <jwerner@...omium.org>, linux-efi@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-block@...r.kernel.org,
	Gwendal Grignou <gwendal@...omium.org>,
	Doug Anderson <dianders@...omium.org>,
	Karel Zak <kzak@...hat.com>
Subject: Re: [PATCH] block: partitions: efi: Always check for alternative GPT
 at end of drive

On 2016-04-26 14:10, Davidlohr Bueso wrote:
> On Tue, 26 Apr 2016, Austin S. Hemmelgarn wrote:
>
>> At the absolute minimum, we should be logging (at least at a warning
>> level) that we had to fall back the the backup GPT.  If somebody is
>> dealing with a disk that had a torn write to the primary GPT, that's
>> one thing, but this could also be caused by any number of other
>> problems (hardware issues, malicious intent, etc), and we need to log
>> that we detected corrupted data.
>
> We already complain about corrupted primary gpt (at a warn level), and
> there's also plenty of verbosity about differences between primary and
> backup (see compare_gpts()), or are you referring to something else?
Ah, you're right, somehow I had missed this.