linux-kernel - Re: [PATCH net-next v2] taskstats: fix nl parsing in accounting/getdelays.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160427.125641.2051987150702050549.davem@davemloft.net>
Date:	Wed, 27 Apr 2016 12:56:41 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	nicolas.dichtel@...nd.com
Cc:	bsingharora@...il.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-wpan@...r.kernel.org,
	aar@...gutronix.de, pablo@...filter.org, kaber@...sh.net,
	kadlec@...ckhole.kfki.hu, pshelar@...ira.com, kuznet@....inr.ac.ru,
	jmorris@...ei.org, yoshfuji@...ux-ipv6.org,
	netfilter-devel@...r.kernel.org, dev@...nvswitch.org,
	steffen.klassert@...unet.com, herbert@...dor.apana.org.au
Subject: Re: [PATCH net-next v2] taskstats: fix nl parsing in
 accounting/getdelays.c

From: Nicolas Dichtel <nicolas.dichtel@...nd.com>
Date: Wed, 27 Apr 2016 17:53:08 +0200

> The type TASKSTATS_TYPE_NULL should always be ignored.
> 
> When jumping to the next attribute, only the length of the current
> attribute should be added, not the length of all nested attributes.
> This last bug was not visible before commit 80df554275c2, because the
> kernel didn't put more than two nested attributes.
> 
> Fixes: a3baf649ca9c ("[PATCH] per-task-delay-accounting: documentation")
> Fixes: 80df554275c2 ("taskstats: use the libnl API to align nlattr on 64-bit")
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>

Applied, thanks.