linux-kernel - Re: [RFC PATCH] lightnvm: expose configuration through sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160427174137.GA10513@kroah.com>
Date:	Wed, 27 Apr 2016 10:41:37 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	"Simon A. F. Lund" <slund@...xlabs.com>
Cc:	linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
	mb@...htnvm.io
Subject: Re: [RFC PATCH] lightnvm: expose configuration through sysfs

On Wed, Apr 27, 2016 at 10:18:57AM -0700, Simon A. F. Lund wrote:
> --- a/include/linux/lightnvm.h
> +++ b/include/linux/lightnvm.h
> @@ -174,6 +174,7 @@ struct nvm_id_group {
>  	u16	cpar;
>  
>  	struct nvm_id_lp_tbl lptbl;
> +	struct kobject kobj;
>  };
>  
>  struct nvm_addr_format {
> @@ -205,6 +206,7 @@ struct nvm_target {
>  	struct list_head list;
>  	struct nvm_tgt_type *type;
>  	struct gendisk *disk;
> +	struct kobject kobj;
>  };
>  
>  struct nvm_tgt_instance {
> @@ -360,6 +362,8 @@ struct nvm_dev {
>  
>  	struct mutex mlock;
>  	spinlock_t lock;
> +
> +	struct kobject kobj;
>  };
>  
>  static inline struct ppa_addr generic_to_dev_addr(struct nvm_dev *dev,

Never use "raw" kobjects in a driver for a device.  You just guaranteed
that userspace tools will not see these devices or attributes, which
implies you didn't really test this using libudev :(

Please use real devices, attached to the real devices your disks already
have in the tree.

And are you sure you didn't just mess up your reference counting by
now having the lifecycle of these structures be dictated by the kobject?

thanks,

greg k-h