linux-kernel - Re: [PATCH v5] mm: SLAB freelist randomization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJcbSZH1H2M2q7Kj_9+61O462uTNwNf5DFG1-qqm32d5rFqWaA@mail.gmail.com>
Date:	Wed, 27 Apr 2016 13:04:17 -0700
From:	Thomas Garnier <thgarnie@...gle.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Christoph Lameter <cl@...ux.com>,
	Pekka Enberg <penberg@...nel.org>,
	David Rientjes <rientjes@...gle.com>,
	Joonsoo Kim <iamjoonsoo.kim@....com>,
	Kees Cook <keescook@...omium.org>,
	Greg Thelen <gthelen@...gle.com>,
	Laura Abbott <labbott@...oraproject.org>,
	kernel-hardening@...ts.openwall.com,
	LKML <linux-kernel@...r.kernel.org>,
	Linux-MM <linux-mm@...ck.org>
Subject: Re: [PATCH v5] mm: SLAB freelist randomization

On Wed, Apr 27, 2016 at 12:16 PM, Andrew Morton
<akpm@...ux-foundation.org> wrote:
> On Wed, 27 Apr 2016 10:20:59 -0700 Thomas Garnier <thgarnie@...gle.com> wrote:
>
>> Provides an optional config (CONFIG_SLAB_FREELIST_RANDOM) to randomize
>> the SLAB freelist.
>
> Forgot this bit?
>

I thought I would change it when we support other kernel heaps.

> From: Andrew Morton <akpm@...ux-foundation.org>
> Subject: mm-slab-freelist-randomization-v5-fix
>
> propagate gfp_t into cache_random_seq_create()
>
> Cc: Christoph Lameter <cl@...ux.com>
> Cc: David Rientjes <rientjes@...gle.com>
> Cc: Greg Thelen <gthelen@...gle.com>
> Cc: Joonsoo Kim <iamjoonsoo.kim@....com>
> Cc: Kees Cook <keescook@...omium.org>
> Cc: Laura Abbott <labbott@...oraproject.org>
> Cc: Pekka Enberg <penberg@...nel.org>
> Cc: Thomas Garnier <thgarnie@...gle.com>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
>
> --- a/mm/slab.c~mm-slab-freelist-randomization-v5-fix
> +++ a/mm/slab.c
> @@ -1262,7 +1262,7 @@ static void freelist_randomize(struct rn
>  }
>
>  /* Create a random sequence per cache */
> -static int cache_random_seq_create(struct kmem_cache *cachep)
> +static int cache_random_seq_create(struct kmem_cache *cachep, gfp_t gfp)
>  {
>         unsigned int seed, count = cachep->num;
>         struct rnd_state state;
> @@ -1271,7 +1271,7 @@ static int cache_random_seq_create(struc
>                 return 0;
>
>         /* If it fails, we will just use the global lists */
> -       cachep->random_seq = kcalloc(count, sizeof(freelist_idx_t), GFP_KERNEL);
> +       cachep->random_seq = kcalloc(count, sizeof(freelist_idx_t), gfp);
>         if (!cachep->random_seq)
>                 return -ENOMEM;
>
> @@ -1290,7 +1290,7 @@ static void cache_random_seq_destroy(str
>         cachep->random_seq = NULL;
>  }
>  #else
> -static inline int cache_random_seq_create(struct kmem_cache *cachep)
> +static inline int cache_random_seq_create(struct kmem_cache *cachep, gfp_t gfp)
>  {
>         return 0;
>  }
> @@ -3999,7 +3999,7 @@ static int enable_cpucache(struct kmem_c
>         int shared = 0;
>         int batchcount = 0;
>
> -       err = cache_random_seq_create(cachep);
> +       err = cache_random_seq_create(cachep, gfp);
>         if (err)
>                 goto end;
>
> _
>