linux-kernel - Re: [PATCH v2 1/3] ARM: dts: exynos: Define vqmmc for SD card and allow disabling regulators on Odroid X/X2/U3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ba632ed9-6e6f-8a5d-5708-9c039e14056e@osg.samsung.com>
Date:	Wed, 27 Apr 2016 17:09:38 -0400
From:	Javier Martinez Canillas <javier@....samsung.com>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Kukjin Kim <kgene@...nel.org>, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
	Tobias Jakobi <tjakobi@...h.uni-bielefeld.de>,
	Marek Szyprowski <m.szyprowski@...sung.com>
Cc:	linux-mmc@...r.kernel.org, linux.amoon@...il.com,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Subject: Re: [PATCH v2 1/3] ARM: dts: exynos: Define vqmmc for SD card and
 allow disabling regulators on Odroid X/X2/U3

Hello Krzysztof,

On 04/27/2016 10:00 AM, Krzysztof Kozlowski wrote:
> The SD-card vmmc-supply contained incorrectly two regulators. The second
> one is ignored. Fix this by defining proper vmmc and vqmmc supplies.
> Additionally these regulators do not have to be always on, so allow
> disabling them to reduce energy consumption.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> 
> ---

Patch looks good to me.

Reviewed-by: Javier Martinez Canillas <javier@....samsung.com>

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America