linux-kernel - Re: [PATCH v2] ACPI/SRAT: fix SRAT order parsing when both LAPIC and X2APIC present

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <32506564.fbJE22l67l@vostro.rjw.lan>
Date:	Wed, 27 Apr 2016 23:23:24 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Lukasz Anaczkowski <lukasz.anaczkowski@...el.com>
Cc:	len.brown@...el.com, mingo@...hat.com, x86@...nel.org,
	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org
Subject: Re: [PATCH v2] ACPI/SRAT: fix SRAT order parsing when both LAPIC and X2APIC present

On Thursday, April 21, 2016 11:29:00 AM Lukasz Anaczkowski wrote:
> SRAT maps APIC ID to proximity domains ids (PXM). Mapping from PXM to
> NUMA node ids is based on order of entries in SRAT table.
> SRAT table has just LAPIC entires or mix of LAPIC and X2APIC entries.
> As long as there are only LAPIC entires, mapping from proximity domain
> id to NUMA node id is as assumed by BIOS. However, once APIC entries are
> mixed, X2APIC entries would be first mapped which causes unexpected NUMA
> node mapping.
> To fix that, change parsing to check each entry against both LAPIC and
> X2APIC so mapping is in the SRAT/PXM order.
> This is supplemental change to the fix made by d81056b5278 (thus
> "Fixes:" tag) and using same mechanism introduced by 9b3fedd (ACPI / tables:
> Add acpi_subtable_proc to ACPI table parsers).
> 
> Fixes: d81056b5278 (Handle apic/x2apic entries in MADT in correct order)
> Signed-off-by: Lukasz Anaczkowski <lukasz.anaczkowski@...el.com>

Applied, thanks!