linux-kernel - Re: [PATCH 4/4] ARM64: dts: rockchip: add dts file for RK3399 evaluation board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <57200E6F.1080507@rock-chips.com>
Date:	Wed, 27 Apr 2016 08:57:19 +0800
From:	"jay.xu" <jay.xu@...k-chips.com>
To:	Doug Anderson <dianders@...omium.org>,
	Heiko Stübner <heiko@...ech.de>
Cc:	lintao <lintao@...k-chips.com>, Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will.deacon@....com>,
	Tao Huang <huangtao@...k-chips.com>,
	David Riley <davidriley@...omium.org>,
	Julius Werner <jwerner@...omium.org>, smbarber@...omium.org,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/4] ARM64: dts: rockchip: add dts file for RK3399
 evaluation board

Hi Doug：

On 2016年04月27日 04:53, Doug Anderson wrote:
> Hi,
>
> On Tue, Apr 26, 2016 at 5:37 AM, Heiko Stübner <heiko@...ech.de> wrote:
>>> +     model = "Rockchip RK3399 Evaluation Board";
>>> +     compatible = "rockchip,rk3399-evb", "rockchip,rk3399",
>>> +                  "google,rk3399evb-rev2", google,rk3399evb-rev1",
>>> +                  "google,rk3399evb-rev0" ;
>>
>> can you check against which compatibles that coreboot really matches?
>>
>> As we said that the evb changed between rev1 and rev2, I would expect the
>> compatible to be something like
>>
>>          compatible = "rockchip,rk3399-evb",  "google,rk3399evb-rev2",
>>                          "rockchip,rk3399";
>>
>> leaving out the rev1 and rev0
>
> What Heiko suggests seems reasonable to me.
>
> It all depends on what your bootloader is doing and what you guys want
> to do.  Chrome OS designs that I've worked on have had board
> strappings that you can read a board ID from and that's how the BIOS
> (like coreboot) will figure out which board ID it is running on.  I'm
> not aware of such strappings on rk3399-evb.  Do they exist?
>
> Of course, even without strappings it's possible to get the bootloader
> to work sanely.  You can either define the revision number at build
> time or you can store the revision number somewhere non-volatile.
>
yes, I will talk with coreboot developer about this, maybe to fix it in 
coreboot and just keep simple in dtsi file.

thanks

Jianqun
>
> -Doug
>
>
>