linux-kernel - Re: [PATCH] parisc: fix a bug when syscall number of tracee is __NR_Linux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160427024511.GA5369@vapier.lan>
Date:	Tue, 26 Apr 2016 22:45:11 -0400
From:	Mike Frysinger <vapier@...too.org>
To:	"Dmitry V. Levin" <ldv@...linux.org>
Cc:	"James E.J. Bottomley" <jejb@...isc-linux.org>,
	Helge Deller <deller@....de>, linux-parisc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] parisc: fix a bug when syscall number of tracee is
 __NR_Linux_syscalls

On 27 Apr 2016 04:56, Dmitry V. Levin wrote:
> Do not load one entry beyond the end of the syscall table when the
> syscall number of a traced process equals to __NR_Linux_syscalls.
> Similar bug with regular processes was fixed by commit 3bb457af4fa8
> ("[PARISC] Fix bug when syscall nr is __NR_Linux_syscalls").
> 
> This bug was found by strace test suite.
> 
> Cc: stable@...r.kernel.org
> Signed-off-by: Dmitry V. Levin <ldv@...linux.org>
> ---
>  arch/parisc/kernel/syscall.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/parisc/kernel/syscall.S b/arch/parisc/kernel/syscall.S
> index c976ebf..57b4836 100644
> --- a/arch/parisc/kernel/syscall.S
> +++ b/arch/parisc/kernel/syscall.S
> @@ -344,7 +344,7 @@ tracesys_next:
>  #endif
>  
>  	cmpib,COND(=),n -1,%r20,tracesys_exit /* seccomp may have returned -1 */
> -	comiclr,>>=	__NR_Linux_syscalls, %r20, %r0
> +	comiclr,>>	__NR_Linux_syscalls, %r20, %r0
>  	b,n	.Ltracesys_nosys
>  
>  	LDREGX  %r20(%r19), %r19

i've deployd your fix to hake, so feel free to give the tests another
run to try and crash the box :).
-mike

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)