lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <57202B97.3010809@huawei.com>
Date:	Wed, 27 Apr 2016 11:01:43 +0800
From:	"Wangnan (F)" <wangnan0@...wei.com>
To:	Florian Fainelli <f.fainelli@...il.com>,
	<linux-kernel@...r.kernel.org>, <acme@...hat.com>
CC:	<ast@...nel.org>, <jolsa@...nel.org>
Subject: Re: [PATCH 2/2] bfp tools: Fix syscall argument



On 2016/4/25 10:34, Florian Fainelli wrote:
> Coverity flagged this under CID 1354884 as a sizeof mismatch, it turns
> out that the argument "attr" passed to syscall should have been a
> pointer to attr in the first place.
>
> Reported-by: coverity (CID 1354884)
> Fixes: 8f9e05fb298f ("perf tools: Fix PowerPC native building")
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> ---
>   tools/build/feature/test-bpf.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/build/feature/test-bpf.c b/tools/build/feature/test-bpf.c
> index 8236df9a46ca..e04ab89a1013 100644
> --- a/tools/build/feature/test-bpf.c
> +++ b/tools/build/feature/test-bpf.c
> @@ -31,5 +31,5 @@ int main(void)
>   	 * Test existence of __NR_bpf and BPF_PROG_LOAD.
>   	 * This call should fail if we run the testcase.
>   	 */
> -	return syscall(__NR_bpf, BPF_PROG_LOAD, attr, sizeof(attr));
> +	return syscall(__NR_bpf, BPF_PROG_LOAD, &attr, sizeof(attr));
>   }
Acked-by: Wang Nan <wangnan0@...wei.com>

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ