linux-kernel - Re: [RESEND PATCH v2 3/7] usb: xhci: plat: Fix suspend/resume when the optional usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87mvofpqib.fsf@intel.com>
Date:	Wed, 27 Apr 2016 08:30:52 +0300
From:	Felipe Balbi <felipe.balbi@...ux.intel.com>
To:	Jisheng Zhang <jszhang@...vell.com>, mathias.nyman@...el.com,
	gregkh@...uxfoundation.org
Cc:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	yendapally.reddy@...adcom.com, Jisheng Zhang <jszhang@...vell.com>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Mathias Nyman <mathias.nyman@...ux.intel.com>
Subject: Re: [RESEND PATCH v2 3/7] usb: xhci: plat: Fix suspend/resume when the optional usb_phy exists


Hi,

Jisheng Zhang <jszhang@...vell.com> writes:
> Commit 7b8ef22ea547 ("usb: xhci: plat: Add USB phy support") adds the
> usb_phy for usb3, but it forgets to shutdown/init the usb_phy in the
> suspend/resume path. This patch fixes this issue by adding missing
> usb_phy related calls.

Fixes: 7b8ef22ea547 ("usb: xhci: plat: Add USB phy support")
Cc: <stable@...r.kernel.org> # v4.1+

> Signed-off-by: Jisheng Zhang <jszhang@...vell.com>
> ---
>  drivers/usb/host/xhci-plat.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> index 9ff89e9..fbd23fd 100644
> --- a/drivers/usb/host/xhci-plat.c
> +++ b/drivers/usb/host/xhci-plat.c
> @@ -313,6 +313,7 @@ static int xhci_plat_suspend(struct device *dev)
>  	if (ret)
>  		return ret;
>  
> +	usb_phy_shutdown(xhci->shared_hcd->usb_phy);
>  	clk_disable_unprepare(xhci->clk);
>  
>  	return ret;
> @@ -328,6 +329,10 @@ static int xhci_plat_resume(struct device *dev)
>  	if (ret)
>  		return ret;
>  
> +	ret = usb_phy_init(xhci->shared_hcd->usb_phy);
> +	if (ret)
> +		return ret;
> +
>  	return xhci_resume(xhci, 0);
>  }

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)