linux-kernel - Re: [RFC v2 7/8] drm/fence: add fence timeline to drm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPj87rN1LYaSY5Yq2FWnZPF32YVYA7-mj5phxTRrAgLaHDqfOQ@mail.gmail.com>
Date:	Wed, 27 Apr 2016 10:23:11 +0200
From:	Daniel Stone <daniel@...ishbar.org>
To:	Gustavo Padovan <gustavo@...ovan.org>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, Daniel Vetter <daniel.vetter@...ll.ch>,
	Riley Andrews <riandrews@...roid.com>,
	dri-devel <dri-devel@...ts.freedesktop.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Arve Hjønnevåg <arve@...roid.com>,
	Gustavo Padovan <gustavo.padovan@...labora.co.uk>,
	John Harrison <John.C.Harrison@...el.com>
Subject: Re: [RFC v2 7/8] drm/fence: add fence timeline to drm_crtc

Hi,

On 26 April 2016 at 00:33, Gustavo Padovan <gustavo@...ovan.org> wrote:
> +static inline struct drm_crtc *fence_to_crtc(struct fence *fence)
> +{
> +       if (fence->ops != &drm_crtc_fence_ops)
> +               return NULL;

Since this is (currently) only used before unconditional dereferences,
maybe turn this into a BUG_ON instead of return NULL?

Cheers,
Daniel