linux-kernel - Re: [PATCH 2/8] char/rtc: legacy RTC is no longer supported on x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Apr 2016 10:35:59 +0200
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	tony.luck@...el.com, geert@...ux-m68k.org, jejb@...isc-linux.org,
	deller@....de, benh@...nel.crashing.org, mpe@...erman.id.au,
	dalias@...c.org, dhowells@...hat.com,
	yasutake.koichi@...panasonic.com, rth@...ddle.net,
	ink@...assic.park.msu.ru, linux-alpha@...r.kernel.org,
	x86@...nel.org, a.zummo@...ertech.it, linux-kernel@...r.kernel.org,
	linux-ia64@...r.kernel.org, linux-parisc@...r.kernel.org,
	linuxppc-dev@...ts.ozlabs.org, linux-sh@...r.kernel.org,
	rtc-linux@...glegroups.com, linux-arch@...r.kernel.org
Subject: Re: [PATCH 2/8] char/rtc: legacy RTC is no longer supported on x86

On 26/04/2016 at 23:44:06 +0200, Arnd Bergmann wrote :
> Commit 3195ef59cb42 ("x86: Do full rtc synchronization with ntp") had
> the side-effect of unconditionally enabling the RTC_LIB symbol on x86,
> which in turn disables the selection of the CONFIG_RTC and
> CONFIG_GEN_RTC drivers that contain a two older implementations of
> the CONFIG_RTC_DRV_CMOS driver.
> 
> This removes x86 from the list.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
Acked-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>

Two down, still four drivers for the x86 RTCs...


> ---
>  drivers/char/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
> index 66b5d48f409a..9bdb629fbaae 100644
> --- a/drivers/char/Kconfig
> +++ b/drivers/char/Kconfig
> @@ -279,7 +279,7 @@ if RTC_LIB=n
>  
>  config RTC
>  	tristate "Enhanced Real Time Clock Support (legacy PC RTC driver)"
> -	depends on ALPHA || (MIPS && MACH_LOONGSON64) || MN10300 || X86
> +	depends on ALPHA || (MIPS && MACH_LOONGSON64) || MN10300
>  	---help---
>  	  If you say Y here and create a character special file /dev/rtc with
>  	  major number 10 and minor number 135 using mknod ("man mknod"), you
> @@ -328,7 +328,7 @@ config JS_RTC
>  config GEN_RTC
>  	tristate "Generic /dev/rtc emulation"
>  	depends on RTC!=y
> -	depends on ALPHA || M68K || MN10300 || PARISC || PPC || X86
> +	depends on ALPHA || M68K || MN10300 || PARISC || PPC
>  	---help---
>  	  If you say Y here and create a character special file /dev/rtc with
>  	  major number 10 and minor number 135 using mknod ("man mknod"), you
> -- 
> 2.7.0
> 

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com