linux-kernel - Re: [PATCH V4 10/18] coresight: tmc: getting rid of multiple read access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57207E49.8050504@arm.com>
Date:	Wed, 27 Apr 2016 09:54:33 +0100
From:	Suzuki K Poulose <Suzuki.Poulose@....com>
To:	Mathieu Poirier <mathieu.poirier@...aro.org>,
	linux-arm-kernel@...ts.infradead.org
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V4 10/18] coresight: tmc: getting rid of multiple read
 access

On 26/04/16 23:10, Mathieu Poirier wrote:
> Allowing multiple readers to access the trace data simultaniously
> via sysFS provides no shortage of opportunity for race condition,
> mandates two variable to be maintained (drvdata::read_count and
> drvdata::reading), makes the code complex and provide little
> advantages, if any.
>
> This patch streamlines the read process by restricting trace data
> access to a single user.  That way drvdata::read_count can
> be eliminated and race conditions (along with faulty error handling)
> in function tmc_open() and tmc_release() eliminated.
>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@...aro.org>

Nice!

Reviewed-by: Suzuki K Poulose <suzuki.poulose@....com>

Suzuki