linux-kernel - Re: [PATCH v2] ARM: reboot: remove duplicated local_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160427172211.395b846a@xhacker>
Date:	Wed, 27 Apr 2016 17:22:11 +0800
From:	Jisheng Zhang <jszhang@...vell.com>
To:	<linux@....linux.org.uk>
CC:	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] ARM: reboot: remove duplicated local_irq_disable()

Dear Russell,

On Wed, 30 Mar 2016 14:45:08 +0800 Jisheng Zhang wrote:

> Once entering machine_halt() and machine_restart(), local_irq_disable()
> is called, and local irq is kept disabled, so the local_irq_disable()
> at the end of these two functions are not necessary, remove it.

Could I put the patch in your patch tracking system?

Thanks,
Jisheng

> 
> Signed-off-by: Jisheng Zhang <jszhang@...vell.com>
> ---
> 
> Since v1:
>  - correct typo in commit msg
> 
>  arch/arm/kernel/reboot.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/arch/arm/kernel/reboot.c b/arch/arm/kernel/reboot.c
> index 71a2ff9..3fa867a 100644
> --- a/arch/arm/kernel/reboot.c
> +++ b/arch/arm/kernel/reboot.c
> @@ -104,8 +104,6 @@ void machine_halt(void)
>  {
>  	local_irq_disable();
>  	smp_send_stop();
> -
> -	local_irq_disable();
>  	while (1);
>  }
>  
> @@ -150,6 +148,5 @@ void machine_restart(char *cmd)
>  
>  	/* Whoops - the platform was unable to reboot. Tell the user! */
>  	printk("Reboot failed -- System halted\n");
> -	local_irq_disable();
>  	while (1);
>  }