linux-kernel - Re: [RESEND PATCH v2 6/7] usb: xhci: plat: add generic PHY support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87twinmm40.fsf@intel.com>
Date:	Wed, 27 Apr 2016 12:34:07 +0300
From:	Felipe Balbi <felipe.balbi@...ux.intel.com>
To:	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Jisheng Zhang <jszhang@...vell.com>
Cc:	mathias.nyman@...el.com, gregkh@...uxfoundation.org,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, yendapally.reddy@...adcom.com
Subject: Re: [RESEND PATCH v2 6/7] usb: xhci: plat: add generic PHY support


Hi,

Heikki Krogerus <heikki.krogerus@...ux.intel.com> writes:
> On Tue, Apr 26, 2016 at 08:57:39PM +0800, Jisheng Zhang wrote:
>> @@ -232,22 +265,44 @@ static int xhci_plat_probe(struct platform_device *pdev)
>>  	if (HCC_MAX_PSA(xhci->hcc_params) >= 4)
>>  		xhci->shared_hcd->can_do_streams = 1;
>>  
>> +	hcd->phy = devm_phy_get(&pdev->dev, "usb2-phy");
>> +	if (IS_ERR(hcd->phy)) {
>> +		ret = PTR_ERR(hcd->phy);
>> +		if (ret == -EPROBE_DEFER)
>> +			goto put_usb3_hcd;
>> +		hcd->phy = NULL;
>> +	}
>> +
>> +	phy = devm_phy_get(&pdev->dev, "usb-phy");
>
> "usb-phy" for what I understand is the USB3 PHY right?

that doesn't appear to be documented anywhere ;-)

> I was unable to find any definition for the phy names for example from
> Documentation/devicetree/bindings/usb/usb-xhci.txt, so I would say
> this needs to be "usb3-phy" and the phy names need to be defined
> somewhere.

yeah, usb3-phy sounds like a better name.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)