linux-kernel - RE: [PATCH v2 4/6] ACPI / osi: Fix default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36DF59CE26D8EE47B0655C516E9CE64028748233@shsmsx102.ccr.corp.intel.com>
Date:	Wed, 27 Apr 2016 09:45:21 +0000
From:	"Chen, Yu C" <yu.c.chen@...el.com>
To:	"Zheng, Lv" <lv.zheng@...el.com>
CC:	Lv Zheng <zetalog@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	"Brown, Len" <len.brown@...el.com>
Subject: RE: [PATCH v2 4/6] ACPI / osi: Fix default _OSI(Darwin) support

Hi Lv,

> -----Original Message-----
> From: Zheng, Lv
> Sent: Wednesday, April 27, 2016 4:55 PM
> To: Wysocki, Rafael J; Rafael J. Wysocki; Brown, Len
> Cc: Zheng, Lv; Lv Zheng; linux-kernel@...r.kernel.org; linux-
> acpi@...r.kernel.org; Chen, Yu C
> Subject: [PATCH v2 4/6] ACPI / osi: Fix default _OSI(Darwin) support
> 
> From: Chen Yu <yu.c.chen@...el.com>
> 
> The following commit always reports positive value when Apple hardware
> queries _OSI("Darwin"):
>  Commit: 7bc5a2bad0b8d9d1ac9f7b8b33150e4ddf197334
>  Subject: ACPI: Support _OSI("Darwin") correctly However since this
> implementation places the judgement in runtime, it breaks acpi_osi=!Darwin
> and cannot return unsupported for _OSI("WinXXX") invoked before invoking
> _OSI("Darwin").
> 
> This patch fixes the issues by reverting the wrong support and implementing
> the default behavior of _OSI("Darwin")/_OSI("WinXXX") on Apple hardware via
> DMI matching.
> 
> Fixes: 7bc5a2bad0b8 ("ACPI: Support _OSI("Darwin") correctly")
> Cc: <stable@...r.kernel.org> # 3.18+
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=92111
> Reported-by: Lukas Wunner <lukas@...ner.de>
> Signed-off-by: Chen Yu <yu.c.chen@...el.com>
> Signed-off-by: Lv Zheng <lv.zheng@...el.com>
> ---
>  drivers/acpi/blacklist.c |   23 ++++++++++++++++++
>  drivers/acpi/osl.c       |   58 ++++++++++++++++++++++++++++++++++++++++---
> ---
>  include/linux/acpi.h     |    1 +
>  3 files changed, 75 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c index
> 96809cd..e947d3e 100644
> --- a/drivers/acpi/blacklist.c
> +++ b/drivers/acpi/blacklist.c
> @@ -133,6 +133,11 @@ int __init acpi_blacklisted(void)
>  	return blacklisted;
>  }
>  #ifdef CONFIG_DMI
> +static int __init dmi_enable_osi_darwin(const struct dmi_system_id *d)
> +{
> +	acpi_dmi_osi_darwin(1, d);	/* enable */
> +	return 0;
> +}
>  static int __init dmi_enable_osi_linux(const struct dmi_system_id *d)  {
>  	acpi_dmi_osi_linux(1, d);	/* enable */
> @@ -331,6 +336,24 @@ static struct dmi_system_id acpi_osi_dmi_table[]
> __initdata = {
>  		},
>  	},
> 
> +	/*
> +	 * Enable _OSI("Darwin") for all apple platforms.
> +	 */
> +	{
> +	.callback = dmi_enable_osi_darwin,
> +	.ident = "Apple hardware",
> +	.matches = {
> +		     DMI_MATCH(DMI_SYS_VENDOR, "Apple INC."),
> +		},
> +	},
> +	{
> +	.callback = dmi_enable_osi_darwin,
> +	.ident = "Apple hardware",
> +	.matches = {
> +		     DMI_MATCH(DMI_SYS_VENDOR, "Apple Computer, INC."),
> +		},
> +	},
> +
The  vendor id should be 'Apple Inc.' and 'Apple Computer, Inc.' instead.

thanks,
yu