linux-kernel - Re: [patch] w1: silence an uninitialized variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <514231461755695@web6g.yandex.ru>
Date:	Wed, 27 Apr 2016 14:14:55 +0300
From:	Evgeniy Polyakov <zbr@...emap.net>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [patch] w1: silence an uninitialized variable warning

Hi Dan

14.04.2016, 12:36, "Dan Carpenter" <dan.carpenter@...cle.com>:
> If kstrtoint() returns -ERANGE then "tmp" is uninitialized.

Looks good to me, please pull it into janitors tree

> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Acked-by: Evgeniy Polaykov <zbr@...emap.net>

> diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
> index 89a7847..bb34362 100644
> --- a/drivers/w1/w1.c
> +++ b/drivers/w1/w1.c
> @@ -335,7 +335,7 @@ static ssize_t w1_master_attribute_store_max_slave_count(struct device *dev,
>          int tmp;
>          struct w1_master *md = dev_to_w1_master(dev);
>
> - if (kstrtoint(buf, 0, &tmp) == -EINVAL || tmp < 1)
> + if (kstrtoint(buf, 0, &tmp) || tmp < 1)
>                  return -EINVAL;
>
>          mutex_lock(&md->mutex);