linux-kernel - Re: [PATCH 2/4] mm, page_alloc: inline the fast path of the zonelist iterator -fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160427123009.GH2858@techsingularity.net>
Date:	Wed, 27 Apr 2016 13:30:09 +0100
From:	Mel Gorman <mgorman@...hsingularity.net>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Vlastimil Babka <vbabka@...e.cz>,
	Jesper Dangaard Brouer <brouer@...hat.com>,
	Linux-MM <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/4] mm, page_alloc: inline the fast path of the zonelist
 iterator -fix

On Wed, Apr 27, 2016 at 01:24:43PM +0100, Mel Gorman wrote:
> Vlastimil Babka pointed out that the nodes allowed by a cpuset are not
> reread if the nodemask changes during an allocation. This potentially
> allows an unnecessary page allocation failure. Moving the retry_cpuset
> label is insufficient but rereading the nodemask before retrying addresses
> the problem.
> 
> This is a fix to the mmotm patch
> mm-page_alloc-inline-the-fast-path-of-the-zonelist-iterator.patch .
> 
> Suggested-by: Vlastimil Babka <vbabka@...e.cz>
> Signed-off-by: Mel Gorman <mgorman@...hsingularity.net>

And this is wrong :( . I'll think again.

-- 
Mel Gorman
SUSE Labs