linux-kernel - Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Apr 2016 09:53:58 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>,
	Alexei Starovoitov <alexei.starovoitov@...il.com>,
	David Ahern <dsahern@...il.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Brendan Gregg <brendan.d.gregg@...il.com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Alexei Starovoitov <ast@...nel.org>,
	He Kuang <hekuang@...wei.com>, Jiri Olsa <jolsa@...hat.com>,
	Masami Hiramatsu <mhiramat@...nel.org>,
	Milian Wolff <milian.wolff@...b.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Stephane Eranian <eranian@...gle.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Vince Weaver <vincent.weaver@...ne.edu>,
	Wang Nan <wangnan0@...wei.com>, Zefan Li <lizefan@...wei.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth
 via sysctl

Em Tue, Apr 26, 2016 at 11:58:10PM +0200, Frederic Weisbecker escreveu:
> On Mon, Apr 25, 2016 at 09:29:28PM -0300, Arnaldo Carvalho de Melo wrote:
> > commit cd544af4f7fede01cb512d52bb3efe62aa19271d
> > Author: Arnaldo Carvalho de Melo <acme@...hat.com>
> > Date:   Thu Apr 21 12:28:50 2016 -0300
> > 
> >     perf core: Allow setting up max frame stack depth via sysctl
> >     
> >     The default remains 127, which is good for most cases, and not even hit
> >     most of the time, but then for some cases, as reported by Brendan, 1024+
> >     deep frames are appearing on the radar for things like groovy, ruby.
> >     
> >     And in some workloads putting a _lower_ cap on this may make sense. One
> >     that is per event still needs to be put in place tho.
> >     
> >     The new file is:
> >     
> >       # cat /proc/sys/kernel/perf_event_max_stack
> >       127
> >     
> >     Chaging it:
> >     
> >       # echo 256 > /proc/sys/kernel/perf_event_max_stack
> >       # cat /proc/sys/kernel/perf_event_max_stack
> >       256
> >     
> >     But as soon as there is some event using callchains we get:
> >     
> >       # echo 512 > /proc/sys/kernel/perf_event_max_stack
> >       -bash: echo: write error: Device or resource busy
> >       #
> >     
> >     Because we only allocate the callchain percpu data structures when there
> >     is a user, which allows for changing the max easily, its just a matter
> >     of having no callchain users at that point.
> >     
> >     Reported-and-Tested-by: Brendan Gregg <brendan.d.gregg@...il.com>
> >     Acked-by: Alexei Starovoitov <ast@...nel.org>
> >     Acked-by: David Ahern <dsahern@...il.com>
> 
> Reviewed-by: Frederic Weisbecker <fweisbec@...il.com>
> 
> I first thought that this should be a tunable per event instead of a global sysctl

Yeah, I'll work on that too.

> but then I realized that we still need a root-only-tunable maximum limit value to oppose
> against any future per event limit and this sysctl value does the job.
 
> Nice patch!

Thanks for reviewieng it!

- Arnaldo