linux-kernel - Re: [PATCH] f2fs: fix to return 0 if err == -ENOENT in f2fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5720BDB5.9000106@kernel.org>
Date:	Wed, 27 Apr 2016 21:25:09 +0800
From:	Chao Yu <chao@...nel.org>
To:	Yunlong Song <yunlong.song@...wei.com>, jaegeuk@...nel.org,
	cm224.lee@...sung.com, yuchao0@...wei.com, sylinux@....com
Cc:	bintian.wang@...wei.com, houpengyang@...wei.com,
	heyunlei@...wei.com, liushuoran@...wei.com, shiguojun@...wei.com,
	linux-f2fs-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] f2fs: fix to return 0 if err == -ENOENT in f2fs_readdir

On 2016/4/27 20:32, Yunlong Song wrote:
> Commit 57b62d29ad5b384775974973087d47755a8c6fcc ("f2fs: fix to report
> error in f2fs_readdir") causes f2fs_readdir to return -ENOENT when
> get_lock_data_page returns -ENOENT. However, the original logic is to
> continue when get_lock_data_page returns -ENOENT, but it forgets to
> reset err to 0.
> 
> This will cause getdents64 incorretly return -ENOENT when lastdirent is
> NULL in getdents64. This will lead to a wrong return value for syscall
> caller.
> 
> Signed-off-by: Yunlong Song <yunlong.song@...wei.com>

Reviewed-by: Chao Yu <yuchao0@...wei.com>