linux-kernel - [PATCH] staging:xgifb: Fix Comparisons should place the constant on the right side of the test warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Apr 2016 09:27:39 -0400
From:	YU Bo <tsu.yubo@...il.com>
To:	Patard <arnaud.patard@...-net.org>,
	Kroah-Hartman <gregkh@...uxfoundation.org>,
	Sim <nicholassimws@...il.com>, Goyal <bhumirks@...il.com>,
	Barnes <clifton.a.barnes@...il.com>,
	Sachdeva <aquannie@...il.com>, Frederick <fabf@...net.be>,
	Ravichandran <janani.rvchndrn@...il.com>, yuzibode@....com
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: [PATCH] staging:xgifb: Fix Comparisons should place the constant on
 the right side of the test warning

Fixed checkpatch.pl's warning 'Comparisons should place the constant on
the right side of the test'

Signed-off-by: YU Bo <tsu.yubo@...il.com>
---
  drivers/staging/xgifb/vb_setmode.c |    4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
index 50c8ea4f5ab7..8bf253c224ad 100644
--- a/drivers/staging/xgifb/vb_setmode.c
+++ b/drivers/staging/xgifb/vb_setmode.c
@@ -1208,7 +1208,7 @@ static void const *XGI_GetLcdPtr(struct XGI330_LCDDataTablStruct const *table,
  		if (pVBInfo->LCDInfo & EnableScalingLCD)
  			tempdx &= (~PanelResInfo);

-		if (table[i].PANELID == tempdx) {
+		if (tempdx == table[i].PANELID) {
  			tempbx = table[i].MASK;
  			tempdx = pVBInfo->LCDInfo;

@@ -3902,7 +3902,7 @@ static struct XGI301C_Tap4TimingStruct const

  	i = 0;
  	while (Tap4TimingPtr[i].DE != 0xFFFF) {
-		if (Tap4TimingPtr[i].DE == tempax)
+		if (tempax == Tap4TimingPtr[i].DE)
  			break;
  		i++;
  	}
--
1.7.10.4