[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <tip-6ed0720a74d90eea51284c07592369d45d56f1f7@git.kernel.org>
Date: Wed, 27 Apr 2016 08:35:33 -0700
From: tip-bot for Masami Hiramatsu <tipbot@...or.com>
To: linux-tip-commits@...r.kernel.org
Cc: hemant@...ux.vnet.ibm.com, mhiramat@...nel.org,
linux-kernel@...r.kernel.org, hpa@...or.com, acme@...hat.com,
ananth@...ux.vnet.ibm.com, tglx@...utronix.de,
peterz@...radead.org, namhyung@...nel.org, mingo@...nel.org
Subject: [tip:perf/core] perf probe: Let probe_file__add_event return 0 if
succeeded
Commit-ID: 6ed0720a74d90eea51284c07592369d45d56f1f7
Gitweb: http://git.kernel.org/tip/6ed0720a74d90eea51284c07592369d45d56f1f7
Author: Masami Hiramatsu <mhiramat@...nel.org>
AuthorDate: Tue, 26 Apr 2016 18:03:04 +0900
Committer: Arnaldo Carvalho de Melo <acme@...hat.com>
CommitDate: Tue, 26 Apr 2016 13:14:58 -0300
perf probe: Let probe_file__add_event return 0 if succeeded
Since other methods return 0 if succeeded (or filedesc), let
probe_file__add_event() return 0 instead of the length of written bytes.
Signed-off-by: Masami Hiramatsu <mhiramat@...nel.org>
Cc: Ananth N Mavinakayanahalli <ananth@...ux.vnet.ibm.com>
Cc: Hemant Kumar <hemant@...ux.vnet.ibm.com>
Cc: Namhyung Kim <namhyung@...nel.org>
Cc: Peter Zijlstra <peterz@...radead.org>
Link: http://lkml.kernel.org/r/20160426090303.11891.18232.stgit@devbox
Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
---
tools/perf/util/probe-file.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tools/perf/util/probe-file.c b/tools/perf/util/probe-file.c
index e3b3b92..3fe6214 100644
--- a/tools/perf/util/probe-file.c
+++ b/tools/perf/util/probe-file.c
@@ -220,8 +220,7 @@ int probe_file__add_event(int fd, struct probe_trace_event *tev)
pr_debug("Writing event: %s\n", buf);
if (!probe_event_dry_run) {
- ret = write(fd, buf, strlen(buf));
- if (ret <= 0) {
+ if (write(fd, buf, strlen(buf)) < (int)strlen(buf)) {
ret = -errno;
pr_warning("Failed to write event: %s\n",
strerror_r(errno, sbuf, sizeof(sbuf)));
Powered by blists - more mailing lists