linux-kernel - Re: [PATCH 1/2] regulator: core: Allow use of "status = disabled" in regulator dts nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <780af88d-a14a-f527-fe0a-1bb50cddc216@redhat.com>
Date:	Wed, 27 Apr 2016 17:52:51 +0200
From:	Hans de Goede <hdegoede@...hat.com>
To:	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Mark Brown <broonie@...nel.org>
Cc:	Liam Girdwood <lgirdwood@...il.com>, Chen-Yu Tsai <wens@...e.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] regulator: core: Allow use of "status = disabled" in
 regulator dts nodes

Hi,

On 27-04-16 17:50, Maxime Ripard wrote:
> Hi Mark,
>
> On Wed, Apr 27, 2016 at 04:01:08PM +0100, Mark Brown wrote:
>> On Wed, Apr 27, 2016 at 04:40:05PM +0200, Hans de Goede wrote:
>>
>>> Or, since regulator_of_get_init_data uses for_each_available_child_of_node
>>> which checks the "status" value we can actually already use
>>> "status=disabled" cool. So this simply already works :)
>>
>> To repeat you really shouldn't have *any* DT nodes for regulators that
>> aren't in use, there should be nothing to put in their nodes.  If
>> there's anything there that's a sign that your DT has problems.
>
> How should we deal with regulators that are on by default but are not
> used in the system then?

I think we've already solved that one, we do list them, thereby giving the
regulator core permission to touch them and then let the regulator core
turn them off for us.

Regards,

Hans