linux-kernel - Re: [PATCH] scripts/spelling.txt: add "fimware" misspelling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5jJvZ6p2OJ=pHi_U0mZchXcc+JSydKu=q2RhHW+nhG8+dQ@mail.gmail.com>
Date:	Wed, 27 Apr 2016 09:14:28 -0700
From:	Kees Cook <keescook@...omium.org>
To:	Zhao Lei <zhaolei@...fujitsu.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Randy Dunlap <rdunlap@...radead.org>,
	Andy Whitcroft <apw@...onical.com>,
	Joe Perches <joe@...ches.com>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scripts/spelling.txt: add "fimware" misspelling

On Tue, Apr 26, 2016 at 9:06 PM, Zhao Lei <zhaolei@...fujitsu.com> wrote:
> Hi, Kees Cook
>
> * From: Kees Cook [mailto:keescook@...omium.org]
>> Sent: Wednesday, April 27, 2016 7:48 AM
>> To: Andrew Morton <akpm@...ux-foundation.org>
>> Cc: Randy Dunlap <rdunlap@...radead.org>; Andy Whitcroft
>> <apw@...onical.com>; Joe Perches <joe@...ches.com>; Zhao Lei
>> <zhaolei@...fujitsu.com>; linux-doc@...r.kernel.org;
>> linux-kernel@...r.kernel.org
>> Subject: [PATCH] scripts/spelling.txt: add "fimware" misspelling
>>
>> A few instances of "fimware" instead of "firmware" were found. Fix these
>> and add it to the spelling.txt file.
>>
> Better to add this change:
>   # grep fimware * -R
>   Documentation/firmware_class/README:    - kernel searchs the fimware image with name
$FIRMWARE directly

Yup! That's actually going in via another batch of spelling fixes
(Randy noticing this one is what made me check for more).

Thanks!

-Kees

>
> Thanks
> Zhaolei
>
>> Reported-by: Randy Dunlap <rdunlap@...radead.org>
>> Signed-off-by: Kees Cook <keescook@...omium.org>
>> ---
>> Looks like spelling.txt changes have been going in through -mm?
>> ---
>>  drivers/media/usb/dvb-usb/dib0700_core.c      | 2 +-
>>  drivers/scsi/bfa/bfi.h                        | 2 +-
>>  drivers/staging/comedi/drivers/daqboard2000.c | 2 +-
>>  scripts/spelling.txt                          | 1 +
>>  4 files changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/media/usb/dvb-usb/dib0700_core.c
>> b/drivers/media/usb/dvb-usb/dib0700_core.c
>> index c16f999b9d7c..bf890c3d9cda 100644
>> --- a/drivers/media/usb/dvb-usb/dib0700_core.c
>> +++ b/drivers/media/usb/dvb-usb/dib0700_core.c
>> @@ -517,7 +517,7 @@ int dib0700_download_firmware(struct usb_device
>> *udev, const struct firmware *fw
>>       if (nb_packet_buffer_size < 1)
>>               nb_packet_buffer_size = 1;
>>
>> -     /* get the fimware version */
>> +     /* get the firmware version */
>>       usb_control_msg(udev, usb_rcvctrlpipe(udev, 0),
>>                                 REQUEST_GET_VERSION,
>>                                 USB_TYPE_VENDOR | USB_DIR_IN, 0, 0,
>> diff --git a/drivers/scsi/bfa/bfi.h b/drivers/scsi/bfa/bfi.h
>> index 97600dcec649..5f698d038b21 100644
>> --- a/drivers/scsi/bfa/bfi.h
>> +++ b/drivers/scsi/bfa/bfi.h
>> @@ -356,7 +356,7 @@ struct bfi_ioc_image_hdr_s {
>>       u8      port0_mode;     /* device mode for port 0       */
>>       u8      port1_mode;     /* device mode for port 1       */
>>       u32     exec;           /* exec vector                  */
>> -     u32     bootenv;        /* fimware boot env             */
>> +     u32     bootenv;        /* firmware boot env            */
>>       u32     rsvd_b[2];
>>       struct bfi_ioc_fwver_s  fwver;
>>       u32     md5sum[BFI_IOC_MD5SUM_SZ];
>> diff --git a/drivers/staging/comedi/drivers/daqboard2000.c
>> b/drivers/staging/comedi/drivers/daqboard2000.c
>> index 57ab6680e3ae..a536a15c1d30 100644
>> --- a/drivers/staging/comedi/drivers/daqboard2000.c
>> +++ b/drivers/staging/comedi/drivers/daqboard2000.c
>> @@ -26,7 +26,7 @@
>>   * Much of the functionality of this driver was determined from reading
>>   * the source code for the Windows driver.
>>   *
>> - * The FPGA on the board requires fimware, which is available from
>> + * The FPGA on the board requires firmware, which is available from
>>   * http://www.comedi.org in the comedi_nonfree_firmware tarball.
>>   *
>>   * Configuration options: not applicable, uses PCI auto config
>> diff --git a/scripts/spelling.txt b/scripts/spelling.txt
>> index 946caf3bd694..fa79c6d2a5b8 100644
>> --- a/scripts/spelling.txt
>> +++ b/scripts/spelling.txt
>> @@ -428,6 +428,7 @@ feautures||features
>>  fetaure||feature
>>  fetaures||features
>>  fileystem||filesystem
>> +fimware||firmware
>>  finanize||finalize
>>  findn||find
>>  finilizes||finalizes
>> --
>> 2.6.3
>>
>>
>> --
>> Kees Cook
>> Chrome OS & Brillo Security
>
>
>
>



-- 
Kees Cook
Chrome OS & Brillo Security