linux-kernel - RE: [PATCH] cpufreq: governor: Change confusing struct field and variable names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <36DF59CE26D8EE47B0655C516E9CE64028748585@shsmsx102.ccr.corp.intel.com>
Date:	Thu, 28 Apr 2016 07:07:09 +0000
From:	"Chen, Yu C" <yu.c.chen@...el.com>
To:	"Rafael J. Wysocki" <rjw@...ysocki.net>
CC:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Viresh Kumar <viresh.kumar@...aro.org>,
	Linux PM list <linux-pm@...r.kernel.org>
Subject: RE: [PATCH] cpufreq: governor: Change confusing struct field and
 variable names

> -----Original Message-----
> From: Rafael J. Wysocki [mailto:rjw@...ysocki.net]
> Sent: Thursday, April 28, 2016 7:19 AM
> To: Linux PM list
> Cc: Linux Kernel Mailing List; Viresh Kumar; Chen, Yu C
> Subject: [PATCH] cpufreq: governor: Change confusing struct field and variable
> names
> 
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> The name of the prev_cpu_wall field in struct cpu_dbs_info is confusing,
> because it doesn't represent wall time, but the previous update time as
> returned by get_cpu_idle_time() (that may be the current value of jiffies_64 in
> some cases, for example).
> 
> Moreover, the names of some related variables in dbs_update() take that
> confusion further.
> 
> Rename all of those things to make their names reflect the purpose more
> accurately.  While at it, drop unnecessary parens from one of the updated
> expressions.
> 
> No functional changes.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> ---
>  drivers/cpufreq/cpufreq_governor.c |   22 +++++++++++-----------
>  drivers/cpufreq/cpufreq_governor.h |    2 +-
>  2 files changed, 12 insertions(+), 12 deletions(-)
Acked-by: Chen Yu <yu.c.chen@...el.com>