linux-kernel - Re: [PATCH 1/6] perf tools: fix incorrect ordering of callchain entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160428084903.GC24122@krava>
Date:	Thu, 28 Apr 2016 10:49:03 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Chris Phlipot <cphlipot0@...il.com>
Cc:	adrian.hunter@...el.com, jolsa@...nel.org, acme@...nel.org,
	peterz@...radead.org, mingo@...hat.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] perf tools: fix incorrect ordering of callchain
 entries

On Thu, Apr 28, 2016 at 01:19:06AM -0700, Chris Phlipot wrote:
> The existing implementation of thread__resolve_callchain, under certain
> circumstances, can assemble callchain entries in the incorrect order.

SNIP

>                 0x558f2a04c774
>                 0x558f2a04dded
>                 rand
>                 __random
>                 ret_from_intr
>                 do_IRQ
>                 handle_irq
>                 handle_edge_irq
>                 handle_irq_event
>                 handle_irq_event_percpu
>                 gen8_irq_handler
> 
> Signed-off-by: Chris Phlipot <cphlipot0@...il.com>

for this patch

Acked-by: Jiri Olsa <jolsa@...nel.org>

can't really ack the rest of the patchset, but it looks good to me

thanks,
jirka