linux-kernel - Re: [PATCH v3 04/16] rtc: sh: provide rtc_class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5905519.cjzepiYx4I@wuerfel>
Date:	Thu, 28 Apr 2016 11:38:47 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	linuxppc-dev@...ts.ozlabs.org
Cc:	Rich Felker <dalias@...c.org>, linux-arch@...r.kernel.org,
	a.zummo@...ertech.it, rtc-linux@...glegroups.com,
	linux-parisc@...r.kernel.org, linux-sh@...r.kernel.org,
	deller@....de, linux-alpha@...r.kernel.org,
	linux-kernel@...r.kernel.org, dhowells@...hat.com,
	linux-m68k@...ts.linux-m68k.org, geert@...ux-m68k.org,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Subject: Re: [PATCH v3 04/16] rtc: sh: provide rtc_class_ops directly

On Thursday 28 April 2016 11:08:41 Arnd Bergmann wrote:
> I only see two of them anyway (dreamcast and sh03), so that should
> be easy enough to do. For instance in arch/sh/boards/mach-sh03/rtc.c,
> the sh03_time_init() function should register a platform driver,
> whose probe function calls devm_rtc_device_register() to register
> with the rtc subsystem. Then you move the entire file to drivers/rtc/
> and change the callers of sh03_time_init() to create the device
> manually (for the classic board file) or drop it (for DT).

Just FYI:

Another look at the sh03_rtc_settimeofday function shows that it's
always been wrong: unlike the set_mmss() function it calls, it should
set all the time fields, not just minutes and seconds.

	Arnd