linux-kernel - Re: [PATCH] mmc: sunxi: Disable eMMC HS-DDR (MMC_CAP_1_8V

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFo4xBpS=4nQzeaRs8HsBRSBsrQEuSvRPjgoQVvPUFK7jA@mail.gmail.com>
Date:	Thu, 28 Apr 2016 12:38:28 +0200
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Chen-Yu Tsai <wens@...e.org>
Cc:	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Hans de Goede <hdegoede@...hat.com>,
	linux-mmc <linux-mmc@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mmc: sunxi: Disable eMMC HS-DDR (MMC_CAP_1_8V_DDR) for
 Allwinner A80

On 26 April 2016 at 17:37, Chen-Yu Tsai <wens@...e.org> wrote:
> eMMC HS-DDR no longer works on the A80, despite it working when support
> for this developed.
>
> Disable it for now.
>
> Signed-off-by: Chen-Yu Tsai <wens@...e.org>

Thanks, applied for fixes!

Kind regards
Uffe

> ---
>
> Hi,
>
> When i worked on this it was working, but now it isn't. Unfortunately I
> don't have my old tree to do a proper bisect. I probably won't have time
> to dig into this issue before v4.6 release, so it's best to disable it
> on the A80 for now.
>
> Thanks.
>
> ---
>  drivers/mmc/host/sunxi-mmc.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
> index 8372a413848c..7fc8b7aa83f0 100644
> --- a/drivers/mmc/host/sunxi-mmc.c
> +++ b/drivers/mmc/host/sunxi-mmc.c
> @@ -1129,6 +1129,11 @@ static int sunxi_mmc_probe(struct platform_device *pdev)
>                                   MMC_CAP_1_8V_DDR |
>                                   MMC_CAP_ERASE | MMC_CAP_SDIO_IRQ;
>
> +       /* TODO MMC DDR is not working on A80 */
> +       if (of_device_is_compatible(pdev->dev.of_node,
> +                                   "allwinner,sun9i-a80-mmc"))
> +               mmc->caps &= ~MMC_CAP_1_8V_DDR;
> +
>         ret = mmc_of_parse(mmc);
>         if (ret)
>                 goto error_free_dma;
> --
> 2.8.1
>