linux-kernel - Re: [patch] pinctrl: baytrail: fix some error handling in debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160428105514.GH10202@lahna.fi.intel.com>
Date:	Thu, 28 Apr 2016 13:55:14 +0300
From:	Mika Westerberg <mika.westerberg@...ux.intel.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Cristina Ciocan <cristina.ciocan@...el.com>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] pinctrl: baytrail: fix some error handling in debugfs

On Wed, Apr 27, 2016 at 11:08:35AM +0300, Dan Carpenter wrote:
> We need to unlock before continuing.  Also the continue was accidentally
> left out on one error path which would lead to a NULL dereference.
> 
> Fixes: 86e3ef812fe3 ('pinctrl: baytrail: Update gpio chip operations')
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Good catch!

Acked-by: Mika Westerberg <mika.westerberg@...ux.intel.com>