linux-kernel - Re: [PATCH v2 1/2] ARM: bcm2835: dt: Add the ethernet to the device trees

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m3wpnhrj42.fsf@euphor.blino.org>
Date:	Thu, 28 Apr 2016 14:52:13 +0200
From:	Olivier Blin <dev@...no.org>
To:	Lubomir Rintel <lkundrak@...sk>, eric@...olt.net
Cc:	Stephen Warren <swarren@...dotorg.org>,
	linux-rpi-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
	Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org,
	Peter Chen <peter.chen@...escale.com>,
	popcornmix <popcornmix@...il.com>
Subject: Re: [PATCH v2 1/2] ARM: bcm2835: dt: Add the ethernet to the device trees

Stephen Warren <swarren@...dotorg.org> writes:

> On 02/04/2016 12:36 AM, Lubomir Rintel wrote:
>> The hub and the ethernet in its port 1 are hardwired on the board.
>> 
>> Compared to the adapters that can be plugged into the USB ports, this
>> one has no serial EEPROM to store its MAC. Nevertheless, the Raspberry Pi
>> has the MAC address for this adapter in its ROM, accessible from its
>> firmware.
>> 
>> U-Boot can read out the address and set the local-mac-address property of the
>> node with "ethernet" alias. Let's add the node so that U-Boot can do its
>> business.
>> 
>> Model B rev2 and Model B+ entries were verified by me, the hierarchy and
>> pid/vid pair for the Version 2 was provided by Olivier Blin. Original
>> Model B is a blind short, though very likely correct.
>
> The series,
> Tested-by: Stephen Warren <swarren@...dotorg.org>
>
> A few nits though...
[...]

Is this still being queued in some tree?
Or does it need more fixes and a resubmit?

Without this, Raspberry Pi devices boot with a random MAC address.

-- 
Olivier Blin - blino