linux-kernel - Re: [PATCH 19/20] md: simplify free_params for kmalloc vs vmalloc fallback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160428160021.GN31489@dhcp22.suse.cz>
Date:	Thu, 28 Apr 2016 18:00:21 +0200
From:	Michal Hocko <mhocko@...nel.org>
To:	Mike Snitzer <snitzer@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>, linux-mm@...ck.org,
	dm-devel@...hat.com, Mikulas Patocka <mpatocka@...hat.com>,
	Shaohua Li <shli@...nel.org>
Subject: Re: [PATCH 19/20] md: simplify free_params for kmalloc vs vmalloc
 fallback

On Thu 28-04-16 11:37:31, Mike Snitzer wrote:
> On Thu, Apr 28 2016 at  9:24am -0400,
> Michal Hocko <mhocko@...nel.org> wrote:
> 
> > From: Michal Hocko <mhocko@...e.com>
> > 
> > Use kvfree rather than DM_PARAMS_[KV]MALLOC specific param flags.
> > 
> > Cc: Shaohua Li <shli@...nel.org>
> > Cc: Mikulas Patocka <mpatocka@...hat.com>
> > Cc: dm-devel@...hat.com
> > Signed-off-by: Michal Hocko <mhocko@...e.com>
> 
> Nack, seriously, this is the 3rd time this patch has been attempted.
> Did you actually test the change?  It'll crash very quickly, see:
> 
> https://www.redhat.com/archives/dm-devel/2016-April/msg00103.html

You are right! My bad I should have checked the other callers!

-- 
Michal Hocko
SUSE Labs