linux-kernel - Re: [PATCH v4 2/4] ARM64: dts: rockchip: add core dtsi file for RK3399 SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160428182938.GA3079@google.com>
Date:	Thu, 28 Apr 2016 11:29:38 -0700
From:	Brian Norris <briannorris@...omium.org>
To:	Jianqun Xu <jay.xu@...k-chips.com>,
	Heiko Stuebner <heiko@...ech.de>
Cc:	mark.rutland@....com, huangtao@...k-chips.com,
	davidriley@...omium.org, pawel.moll@....com,
	ijc+devicetree@...lion.org.uk, catalin.marinas@....com,
	will.deacon@....com, dianders@...omium.org, smbarber@...omium.org,
	lintao@...k-chips.com, linux-rockchip@...ts.infradead.org,
	devicetree@...r.kernel.org, robh+dt@...nel.org,
	linux-arm-kernel@...ts.infradead.org, galak@...eaurora.org,
	jwerner@...omium.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/4] ARM64: dts: rockchip: add core dtsi file for
 RK3399 SoCs

One more thing:

On Thu, Apr 28, 2016 at 09:03:53AM -0700, Brian Norris wrote:
> Hi Heiko, Jianqun,
> 
> On Wed, Apr 27, 2016 at 03:54:51PM +0800, Jianqun Xu wrote:
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> > new file mode 100644
> > index 0000000..5a8a915
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> > @@ -0,0 +1,1022 @@
> [...]
> > +	sdhci: sdhci@...30000 {
> > +		compatible = "rockchip,rk3399-sdhci-5.1", "arasan,sdhci-5.1";
> 
> Not to rain on the parade too much, as this is already applied, but is
> the "rockchip,rk3399-sdhci-5.1" string documented anywhere? I don't see
> it.

According to the latest binding for "arasan,sdhci-5.1", the "phy" and
"phy-names" properties are required. Fortunately, this device stays
"disabled" for now in your EVB DTS. But just FYI.

> > +		reg = <0x0 0xfe330000 0x0 0x10000>;
> > +		interrupts = <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>;
> > +		clocks = <&cru SCLK_EMMC>, <&cru ACLK_EMMC>;
> > +		clock-names = "clk_xin", "clk_ahb";
> > +		status = "disabled";
> > +	};

Brian