linux-kernel - Re: [PATCH] MD: make bio mergeable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.20.1604281933200.31165@diagnostix.dwd.de>
Date:	Thu, 28 Apr 2016 20:00:22 +0000 (UTC)
From:	Holger Kiehl <Holger.Kiehl@....de>
To:	Shaohua Li <shli@...com>
cc:	linux-block@...r.kernel.org,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-raid <linux-raid@...r.kernel.org>, qkrwngud825@...il.com,
	Kernel-team@...com, Ming Lei <ming.lei@...onical.com>,
	Jens Axboe <axboe@...com>, Neil Brown <neilb@...e.de>
Subject: Re: [PATCH] MD: make bio mergeable

Hello,

On Mon, 25 Apr 2016, Shaohua Li wrote:

> blk_queue_split marks bio unmergeable, which makes sense for normal bio.
> But if dispatching the bio to underlayer disk, the blk_queue_split
> checks are invalid, hence it's possible the bio becomes mergeable.
> 
> In the reported bug, this bug causes trim against raid0 performance slash
> https://bugzilla.kernel.org/show_bug.cgi?id=117051
> 
This patch makes a huge difference. On a system with two Samsung 850 Pro
in a MD Raid0 setup the time for fstrim went down from ~30min to 18sec!

However, on another system with two Intel P3700 1.6TB NVMe PCIe SSD's
also setup as one big MD Raid0, the patch does not make any difference
at all. fstrim takes more then 4 hours!

Any idea what could be wrong?

Regards,
Holger


> Reported-by: Park Ju Hyung <qkrwngud825@...il.com>
> Fixes: 6ac45aeb6bca(block: avoid to merge splitted bio)
> Cc: stable@...r.kernel.org (v4.3+)
> Cc: Ming Lei <ming.lei@...onical.com>
> Cc: Jens Axboe <axboe@...com>
> Cc: Neil Brown <neilb@...e.de>
> Signed-off-by: Shaohua Li <shli@...com>
> ---
>  drivers/md/md.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 194580f..14d3b37 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -284,6 +284,8 @@ static blk_qc_t md_make_request(struct request_queue *q, struct bio *bio)
>  	 * go away inside make_request
>  	 */
>  	sectors = bio_sectors(bio);
> +	/* bio could be mergeable after passing to underlayer */
> +	bio->bi_rw &= ~REQ_NOMERGE;
>  	mddev->pers->make_request(mddev, bio);
>  
>  	cpu = part_stat_lock();
> -- 
> 2.8.0.rc2
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>