linux-kernel - Re: [PATCH resend] powerpc: enable qspinlock and its virtualization support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57227BAA.7040807@hpe.com>
Date:	Thu, 28 Apr 2016 17:07:54 -0400
From:	Waiman Long <waiman.long@....com>
To:	Pan Xinhui <xinhui@...ux.vnet.ibm.com>
CC:	<linux-kernel@...r.kernel.org>,
	<virtualization@...ts.linux-foundation.org>,
	<linuxppc-dev@...ts.ozlabs.org>, <peterz@...radead.org>,
	Boqun Feng <boqun.feng@...il.com>,
	Paul Mackerras <paulus@...ba.org>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Michael Ellerman <mpe@...erman.id.au>, <jeremy@...p.org>,
	<chrisw@...s-sol.org>, <akataria@...are.com>,
	<rusty@...tcorp.com.au>, <gwshan@...ux.vnet.ibm.com>,
	<adam.buchbinder@...il.com>, <tglx@...utronix.de>,
	<marc.zyngier@....com>
Subject: Re: [PATCH resend] powerpc: enable qspinlock and its virtualization
 support

On 04/28/2016 06:55 AM, Pan Xinhui wrote:
> From: Pan Xinhui<xinhui.pan@...ux.vnet.ibm.com>
>
> This patch aims to enable qspinlock on PPC. And on pseries platform, it also support
> paravirt qspinlock.
>
> Signed-off-by: Pan Xinhui<xinhui.pan@...ux.vnet.ibm.com>
> ---
>   arch/powerpc/include/asm/qspinlock.h               | 37 +++++++++++++++
>   arch/powerpc/include/asm/qspinlock_paravirt.h      | 36 +++++++++++++++
>   .../powerpc/include/asm/qspinlock_paravirt_types.h | 13 ++++++
>   arch/powerpc/include/asm/spinlock.h                | 31 ++++++++-----
>   arch/powerpc/include/asm/spinlock_types.h          |  4 ++
>   arch/powerpc/kernel/paravirt.c                     | 52 ++++++++++++++++++++++
>   arch/powerpc/lib/locks.c                           | 32 +++++++++++++
>   arch/powerpc/platforms/pseries/setup.c             |  5 +++
>   8 files changed, 198 insertions(+), 12 deletions(-)
>   create mode 100644 arch/powerpc/include/asm/qspinlock.h
>   create mode 100644 arch/powerpc/include/asm/qspinlock_paravirt.h
>   create mode 100644 arch/powerpc/include/asm/qspinlock_paravirt_types.h
>   create mode 100644 arch/powerpc/kernel/paravirt.c
>
>

This is just an enablement patch. You will also need a patch to activate 
qspinlock for, at lease, some PPC configs. Right?

It has dependency on the pv_wait() patch that I sent out extend the 
parameter list. Some performance data on how PPC system will perform 
with and without qspinlock will also be helpful data points.

Cheers,
Longman