linux-kernel - Re: [PATCH v7 2/9] ARM: dts: am437x: Add missing compatibles to PWM binding documents

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 28 Apr 2016 16:11:59 -0500
From:	"Franklin S Cooper Jr." <fcooper@...com>
To:	Rob Herring <robh@...nel.org>
CC:	<thierry.reding@...il.com>, <tony@...mide.com>, <paul@...an.com>,
	<t-kristo@...com>, <linux-pwm@...r.kernel.org>,
	<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-omap@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-clk@...r.kernel.org>, <vigneshr@...com>, <nsekhar@...com>
Subject: Re: [PATCH v7 2/9] ARM: dts: am437x: Add missing compatibles to PWM
 binding documents


Rob,
On 04/28/2016 04:07 PM, Rob Herring wrote:
> On Tue, Apr 26, 2016 at 05:36:42PM -0500, Franklin S Cooper Jr wrote:
>> There are several SOC specific compatibles for ECAP, EHRPWM and PWMMS
>> that are in use but aren't properly documented. Therefore, fix this
>> by adding the compatibles to the appropriate binding documents.
>>
>> While at it make minor corrections to the binding document.
>>
>> Signed-off-by: Franklin S Cooper Jr <fcooper@...com>
>> ---
>>  .../devicetree/bindings/pwm/pwm-tiecap.txt          | 12 ++++++++++--
>>  .../devicetree/bindings/pwm/pwm-tiehrpwm.txt        | 12 ++++++++++--
>>  .../devicetree/bindings/pwm/pwm-tipwmss.txt         | 21 +++++++++++++++++++--
>>  3 files changed, 39 insertions(+), 6 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt b/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
>> index fb81179..788da6c 100644
>> --- a/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
>> +++ b/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
>> @@ -2,8 +2,9 @@ TI SOC ECAP based APWM controller
>>  
>>  Required properties:
>>  - compatible: Must be "ti,<soc>-ecap".
>> -  for am33xx - compatible = "ti,am33xx-ecap";
>> -  for da850  - compatible = "ti,da850-ecap", "ti,am33xx-ecap";
>> +  for am33xx  - compatible = "ti,am33xx-ecap";
>> +  for am4372  - compatible = "ti,am4372-ecap", "ti,am33xx-ecap";
>> +  for da850   - compatible = "ti,da850-ecap", "ti,am33xx-ecap";
>>  - #pwm-cells: should be 3. See pwm.txt in this directory for a description of
>>    the cells format. The PWM channel index ranges from 0 to 4. The only third
>>    cell flag supported by this binding is PWM_POLARITY_INVERTED.
>> @@ -22,6 +23,13 @@ ecap0: ecap@0 { /* ECAP on am33xx */
>>  	ti,hwmods = "ecap0";
>>  };
>>  
>> +ecap0: ecap@0 { /* ECAP on am4372 */
> 
> The unit address is wrong.
> 
>> +	compatible = "ti,am4372-ecap", "ti,am33xx-ecap";
>> +	#pwm-cells = <3>;
>> +	reg = <0x48300100 0x80>;
>> +	ti,hwmods = "ecap0";
>> +};
>> +
>>  ecap0: ecap@0 { /* ECAP on da850 */
>>  	compatible = "ti,da850-ecap", "ti,am33xx-ecap";
>>  	#pwm-cells = <3>;
>> diff --git a/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt b/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt
>> index 9c100b2..99b544f 100644
>> --- a/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt
>> +++ b/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt
>> @@ -2,8 +2,9 @@ TI SOC EHRPWM based PWM controller
>>  
>>  Required properties:
>>  - compatible: Must be "ti,<soc>-ehrpwm".
>> -  for am33xx - compatible = "ti,am33xx-ehrpwm";
>> -  for da850  - compatible = "ti,da850-ehrpwm", "ti,am33xx-ehrpwm";
>> +  for am33xx  - compatible = "ti,am33xx-ehrpwm";
>> +  for am4372  - compatible = "ti,am4372-ehrpwm", "ti,am33xx-ehrpwm";
>> +  for da850   - compatible = "ti,da850-ehrpwm", "ti,am33xx-ehrpwm";
>>  - #pwm-cells: should be 3. See pwm.txt in this directory for a description of
>>    the cells format. The only third cell flag supported by this binding is
>>    PWM_POLARITY_INVERTED.
>> @@ -22,6 +23,13 @@ ehrpwm0: ehrpwm@0 { /* EHRPWM on am33xx */
>>  	ti,hwmods = "ehrpwm0";
>>  };
>>  
>> +ehrpwm0: ehrpwm@0 { /* EHRPWM on am4372 */
> 
> ditto
> 
> Otherwise,
> 
> Acked-by: Rob Herring <robh@...nel.org>
> 


Yes, the unit address is wrong but it is wrong in several places. I
added it like that to match what the other bindings are doing. However,
patches 3 and 4 fixes these unit address problems for all the bindings
all together to make things clear.