linux-kernel - Re: [PATCH] mm/zsmalloc: don't fail if can't create debugfs info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160429003824.GC4920@swordfish>
Date:	Fri, 29 Apr 2016 09:38:24 +0900
From:	Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Dan Streetman <ddstreet@...e.org>,
	Minchan Kim <minchan@...nel.org>,
	Nitin Gupta <ngupta@...are.org>,
	Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
	Seth Jennings <sjenning@...hat.com>,
	Yu Zhao <yuzhao@...gle.com>, Linux-MM <linux-mm@...ck.org>,
	Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Dan Streetman <dan.streetman@...onical.com>
Subject: Re: [PATCH] mm/zsmalloc: don't fail if can't create debugfs info

On (04/28/16 15:07), Andrew Morton wrote:
> Needed a bit of tweaking due to
> http://ozlabs.org/~akpm/mmotm/broken-out/zsmalloc-reordering-function-parameter.patch

Thanks.

> From: Dan Streetman <ddstreet@...e.org>
> Subject: mm/zsmalloc: don't fail if can't create debugfs info
> 
> Change the return type of zs_pool_stat_create() to void, and
> remove the logic to abort pool creation if the stat debugfs
> dir/file could not be created.
> 
> The debugfs stat file is for debugging/information only, and doesn't
> affect operation of zsmalloc; there is no reason to abort creating
> the pool if the stat file can't be created.  This was seen with
> zswap, which used the same name for all pool creations, which caused
> zsmalloc to fail to create a second pool for zswap if
> CONFIG_ZSMALLOC_STAT was enabled.

no real objections from me. given that both zram and zswap now provide
unique names for zsmalloc stats dir, this patch does not fix any "real"
(observed) problem /* ENOMEM in debugfs_create_dir() is a different
case */.  so it's more of a cosmetic patch.

FWIW,
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>

	-ss