linux-kernel - Re: [PATCH 2/5] mtd: nand: gpmi: document the clocks and clock-names in DT property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160429105023.0209995a@bbrezillon>
Date:	Fri, 29 Apr 2016 10:50:23 +0200
From:	Boris Brezillon <boris.brezillon@...e-electrons.com>
To:	Han Xu <han.xu@....com>
Cc:	<shijie.huang@....com>, <dwmw2@...radead.org>,
	<computersforpeace@...il.com>, <standby24x7@...il.com>,
	<jkosina@...e.cz>, <fabio.estevam@...escale.com>,
	<fransklaver@...il.com>, <hofrat@...dl.org>,
	linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] mtd: nand: gpmi: document the clocks and
 clock-names in DT property

Hi Han,

On Tue, 23 Feb 2016 17:04:50 -0600
Han Xu <han.xu@....com> wrote:

> add the clocks and clock-names in DT property, gpmi-io clock is
> mandatory for all platforms, but some platforms, such as i.MX6Q may
> need more extra clocks for submodules. More details please refer to the
> SoC reference manual.
> 
> Signed-off-by: Han Xu <han.xu@....com>
> ---
>  Documentation/devicetree/bindings/mtd/gpmi-nand.txt | 9 +++++++++

Please make sure you add the DT maintainers (and the DT ML) in Cc when
you update DT bindings.

Best Regards,

Boris

>  1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mtd/gpmi-nand.txt b/Documentation/devicetree/bindings/mtd/gpmi-nand.txt
> index d02acaf..c8d0e2f 100644
> --- a/Documentation/devicetree/bindings/mtd/gpmi-nand.txt
> +++ b/Documentation/devicetree/bindings/mtd/gpmi-nand.txt
> @@ -13,6 +13,13 @@ Required properties:
>      and GPMI DMA channel ID.
>      Refer to dma.txt and fsl-mxs-dma.txt for details.
>    - dma-names: Must be "rx-tx".
> +  - clocks : The clocks needed by the gpmi controller. This field varies
> +    depends on the SoC design, "gpmi-io" is mandatory but some platforms may
> +    need several extra clocks, such as i.MX6Q, it requires "gpmi_apb,
> +    gpmi_bch, gpmi_bch_apb and per1_bch" for all submodules. Please refer to
> +    the HW design manual.
> +  - clock-names : the name of the clocks, please refer to the HW design
> +    manual.
>  
>  Optional properties:
>    - nand-on-flash-bbt: boolean to enable on flash bbt option if not
> @@ -51,6 +58,8 @@ gpmi-nand@...0c000 {
>  	interrupt-names = "bch";
>  	dmas = <&dma_apbh 4>;
>  	dma-names = "rx-tx";
> +	clocks = <&clks 50>,;
> +	clock-names = "gpmi_io";
>  
>  	partition@0 {
>  	...



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com