linux-kernel - Re: [PATCH] Use existing helper to convert "on/off" to boolean

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160429092145.GC21977@dhcp22.suse.cz>
Date:	Fri, 29 Apr 2016 11:21:45 +0200
From:	Michal Hocko <mhocko@...nel.org>
To:	Minfei Huang <mnghuan@...il.com>
Cc:	akpm@...ux-foundation.org, labbott@...oraproject.org,
	rjw@...ysocki.net, mgorman@...hsingularity.net, vbabka@...e.cz,
	rientjes@...gle.com, kirill.shutemov@...ux.intel.com,
	iamjoonsoo.kim@....com, izumi.taku@...fujitsu.com,
	alexander.h.duyck@...hat.com, hannes@...xchg.org,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Use existing helper to convert "on/off" to boolean

On Fri 29-04-16 17:07:42, Minfei Huang wrote:
> On 04/29/16 at 10:04P, Michal Hocko wrote:
> > On Fri 29-04-16 13:47:04, Minfei Huang wrote:
> > > It's more convenient to use existing function helper to convert string
> > > "on/off" to boolean.
> > 
> > But kstrtobool in linux-next only does "This routine returns 0 iff the
> > first character is one of 'Yy1Nn0'" so it doesn't know about on/off.
> > Or am I missing anything?
> 
> Hi, Michal.
> 
> Thanks for your reply.
> 
> Following is the kstrtobool comment from linus tree, which has explained
> that this function can parse "on"/"off" string. Also Kees Cook has
> posted such patch to fix this issue as well. So I think it's safe to fix
> it.

OK, I was looking at wrong tree and missed a81a5a17d44b ("lib: add
"on"/"off" support to kstrtobool")

Sorry about the confusion. Feel free to add
Acked-by: Michal Hocko <mhocko@...e.com>
-- 
Michal Hocko
SUSE Labs