linux-kernel - Re: [PATCH v2 1/2][UPDATE] PM / OPP: add non-OF versions of dev_pm_opp_{cpumask_,}remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <572329DF.2060209@arm.com>
Date:	Fri, 29 Apr 2016 10:31:11 +0100
From:	Sudeep Holla <sudeep.holla@....com>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	Sudeep Holla <sudeep.holla@....com>, linux-kernel@...r.kernel.org,
	Viresh Kumar <vireshk@...nel.org>, Nishanth Menon <nm@...com>,
	Stephen Boyd <sboyd@...eaurora.org>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>, linux-pm@...r.kernel.org
Subject: Re: [PATCH v2 1/2][UPDATE] PM / OPP: add non-OF versions of
 dev_pm_opp_{cpumask_,}remove_table



On 29/04/16 10:28, Viresh Kumar wrote:
> This isn't V2, but V3
>
> On 29-04-16, 10:22, Sudeep Holla wrote:
>> Functions dev_pm_opp_of_{cpumask_,}remove_table removes/frees all the
>> static OPP entries associated with the device and/or all cpus(in case
>> of cpumask) that are created from DT.
>>
>> However the OPP entries are populated reading from the firmware or some
>> different method using dev_pm_opp_add are marked dynamic and can't be
>> removed using above functions.
>>
>> This patch adds non DT/OF versions of dev_pm_opp_{cpumask_,}remove_table
>> to support the above mentioned usecase.
>>
>> This is in preparation to make use of the same in scpi-cpufreq.c
>>
>> Cc: Viresh Kumar <vireshk@...nel.org>
>> Cc: Nishanth Menon <nm@...com>
>> CC: Stephen Boyd <sboyd@...eaurora.org>
>> Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>
>> Cc: linux-pm@...r.kernel.org
>> Signed-off-by: Sudeep Holla <sudeep.holla@....com>
>> ---
>>   drivers/base/power/opp/core.c | 56 ++++++++++++++++++++++++++++++----------
>>   drivers/base/power/opp/cpu.c  | 59 ++++++++++++++++++++++++++++++++-----------
>>   include/linux/pm_opp.h        | 10 ++++++++
>>   3 files changed, 96 insertions(+), 29 deletions(-)
>>
>> v1->v2:
>> 	- Instead of renaming OF versions, created non-OF versions of
>> 	  dev_pm_opp_{cpumask_,}remove_table as suggested by Viresh
>>
>
> You should have added v2->v3 here
>

No, thought I will post v3 of both the patches with your ACK so that
it's easy for Rafael to pick up if he has no comments :)

>> This version also updates all the errors in documentation and changes
>> to use remove_all rather than remove_dyn.
>
> But all that isn't going to be part of the history, so it should be fine :)
>
> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
>

Thanks

-- 
Regards,
Sudeep