linux-kernel - Re: [PATCH 2/6] x86/boot: Move compressed kernel to end of decompression buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160429095130.GA29875@gmail.com>
Date:	Fri, 29 Apr 2016 11:51:30 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Kees Cook <keescook@...omium.org>
Cc:	Yinghai Lu <yinghai@...nel.org>, Ingo Molnar <mingo@...hat.com>,
	Baoquan He <bhe@...hat.com>, "H. Peter Anvin" <hpa@...or.com>,
	Borislav Petkov <bp@...en8.de>,
	Vivek Goyal <vgoyal@...hat.com>,
	Andy Lutomirski <luto@...nel.org>,
	Lasse Collin <lasse.collin@...aani.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Dave Young <dyoung@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/6] x86/boot: Move compressed kernel to end of
 decompression buffer


* Ingo Molnar <mingo@...nel.org> wrote:

> * Kees Cook <keescook@...omium.org> wrote:
> 
> > I don't agree. We do still have embedded systems running x86 kernels, and we 
> > have cases where we're running multiple kernels in memory (like kdump). I think 
> > the memory savings is worth the complexity, especially since the complexity is 
> > being reduced up by this patch. [...]
> 
> Hm, so can we quantify it, how much are the temporary memory savings in practice? 
> I'd like to see actual vmlinuz numbers with say a defconfig and with a distro 
> config.

Btw., with the extra explanations added to the changelog I am happy with the 
series and have applied it to x86/boot and pushed it out. If we decide to simplify 
the code it will be much easier to simplify correctly working, well documented 
code.

It would be nice to do another pass at the in-code comments and at the general 
code structure, to make sure all this is properly explained and structured.

Thanks,

	Ingo