linux-kernel - Re: [PATCH] ARM: dts: omap5-igep0050: Correct hdmi regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 29 Apr 2016 13:22:32 +0300
From:	Peter Ujfalusi <peter.ujfalusi@...com>
To:	<tony@...mide.com>
CC:	<linux-omap@...r.kernel.org>, <devicetree@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: dts: omap5-igep0050: Correct hdmi regulator

On 04/29/16 13:21, Peter Ujfalusi wrote:
> ldo7_reg should not work as regulator since it is set to 'disabled' state
> in the omap5-board-common.dtsi and the state is not changed to 'okay'
> this means that the ldo7_reg is not available to be used in the igep0050
> DTS file.
> ldo4_reg is used by all other OMAP5 boards and this is most likely the
> correct regulator to use with hdmi.
> The hdmi needs 1.8V, but the ldo7_reg, based on the dtsi is 2V only.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...com>
> ---
> Tony,
> 
> I don't have access to the schematics, but I believe tha the ldo7_reg is not the
> correct regulator to be used for hdmi.
> 
> If you have access and it is really ldo7_reg, then we should have this in the
> omap5-igep0050.dts file:
> 
> &ldo5_reg {

ldo7_reg, obviously ;)

> 	status = "okay";
> 	regulator-min-microvolt = <1800000>;
> 	regulator-max-microvolt = <1800000>;
> };
> 
> Regards,
> Peter
> 
>  arch/arm/boot/dts/omap5-igep0050.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/omap5-igep0050.dts b/arch/arm/boot/dts/omap5-igep0050.dts
> index 46ecb1dd3b5c..6c8d40327c68 100644
> --- a/arch/arm/boot/dts/omap5-igep0050.dts
> +++ b/arch/arm/boot/dts/omap5-igep0050.dts
> @@ -20,7 +20,7 @@
>  };
>  
>  &hdmi {
> -	vdda-supply = <&ldo7_reg>;
> +	vdda-supply = <&ldo4_reg>;
>  };
>  
>  &i2c4 {
> 


-- 
Péter