linux-kernel - Re: [PATCH v4 04/13] USB: ch341: fix USB buffer allocations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <856a45c97aff7ce525e1bb3e1dee3f2f@chown.ath.cx>
Date:	Fri, 29 Apr 2016 17:12:48 +0200
From:	Grigori Goronzy <greg@...wn.ath.cx>
To:	Johan Hovold <johan@...nel.org>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Johan Hovold <jhovold@...il.com>
Subject: Re: [PATCH v4 04/13] USB: ch341: fix USB buffer allocations

On 2016-04-29 14:52, Johan Hovold wrote:
>> @@ -168,9 +168,9 @@ static int ch341_set_handshake(struct usb_device 
>> *dev, u8 control)
>> 
>>  static int ch341_get_status(struct usb_device *dev, struct 
>> ch341_private *priv)
>>  {
>> -	char *buffer;
>> +	unsigned char *buffer;
>>  	int r;
>> -	const unsigned size = 8;
>> +	const unsigned size = 2;
> 
> Did you reply to Oliver's comment about this change? Are you sure this
> won't break some old device expecting to be asked for eight bytes even
> if only two are returned?
> 

I'll just drop this change.

Grigori