linux-kernel - Re: [PATCH] mtd: nand: gpmi: get correct free oob space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB5PR0401MB1845A3F3CF3B52E1257B344A97660@DB5PR0401MB1845.eurprd04.prod.outlook.com>
Date:	Fri, 29 Apr 2016 14:35:10 +0000
From:	Han Xu <han.xu@....com>
To:	Boris Brezillon <boris.brezillon@...e-electrons.com>
CC:	"richard@....at" <richard@....at>,
	"dwmw2@...radead.org" <dwmw2@...radead.org>,
	"computersforpeace@...il.com" <computersforpeace@...il.com>,
	"linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mtd: nand: gpmi: get correct free oob space



________________________________________
From: Boris Brezillon <boris.brezillon@...e-electrons.com>
Sent: Friday, April 29, 2016 2:31 AM
To: Han Xu
Cc: richard@....at; dwmw2@...radead.org; computersforpeace@...il.com; linux-mtd@...ts.infradead.org; linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: nand: gpmi: get correct free oob space

Hi Han,

On Wed, 13 Apr 2016 00:43:51 +0200
Boris Brezillon <boris.brezillon@...e-electrons.com> wrote:

> Hi Han,
>
> On Tue, 12 Apr 2016 17:06:33 -0500
> Han Xu <han.xu@....com> wrote:
>
> > change the way to calculate pagesize to get correct free oob space for
> > legacy_set_geometry function.
>
> Are you sure it's safe to expose free OOB bytes in this case? Do you
> know why it wasn't done before?

You did not answer this question. Do you want me to drop this patch. If
that's not the case, can you confirm it does not break platforms that
didn't have those free OOB bytes exposed before this change.

I think it's safe to expose the free OOB and also tested on my side, no
issue found.

Thanks,

Boris


--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com