linux-kernel - RE: [PATCH] mptsas: fix checks for dma mapping errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e4d00c4701ebcea4239019574ffc25fd@mail.gmail.com>
Date:	Fri, 29 Apr 2016 13:13:36 -0600
From:	Sathya Prakash Veerichetty <sathya.prakash@...adcom.com>
To:	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Alexey Khoroshilov <khoroshilov@...ras.ru>
Cc:	Sreekanth Reddy <Sreekanth.Reddy@...gotech.com>,
	Chaitra Basappa <chaitra.basappa@...adcom.com>,
	Suganath Prabu Subramani 
	<suganath-prabu.subramani@...adcom.com>,
	PDL-MPT-FUSIONLINUX <mpt-fusionlinux.pdl@...adcom.com>,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	ldv-project@...uxtesting.org
Subject: RE: [PATCH] mptsas: fix checks for dma mapping errors

Please consider this patch as Ack-by: Sathya Prakash
Veerichetty<sathya.prakash@...adcom.com>

PS: We don't have test environment to test this patch as this is for an
old controller.  So ACKing based on code review and similar mpt3sas driver
code.

-----Original Message-----
From: Martin K. Petersen [mailto:martin.petersen@...cle.com]
Sent: Wednesday, April 27, 2016 7:18 PM
To: Alexey Khoroshilov
Cc: Sreekanth Reddy; Sathya Prakash; Chaitra P B; Suganath Prabu
Subramani; MPT-FusionLinux.pdl@...adcom.com; linux-scsi@...r.kernel.org;
linux-kernel@...r.kernel.org; ldv-project@...uxtesting.org
Subject: Re: [PATCH] mptsas: fix checks for dma mapping errors

>>>>> "Alexey" == Alexey Khoroshilov <khoroshilov@...ras.ru> writes:

Alexey> mptsas_smp_handler() checks for dma mapping errors by comparison
Alexey> returned address with zero, while pci_dma_mapping_error() should
Alexey> be used.

Broadcom folks, please review!

-- 
Martin K. Petersen	Oracle Linux Engineering