linux-kernel - Re: [PATCH] tpm: select ANON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160429194138.GA22950@intel.com>
Date:	Fri, 29 Apr 2016 22:41:38 +0300
From:	Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Peter Huewe <peterhuewe@....de>,
	Marcel Selhorst <tpmdd@...horst.net>,
	Jason Gunthorpe <jgunthorpe@...idianresearch.com>,
	Stefan Berger <stefanb@...ux.vnet.ibm.com>,
	tpmdd-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tpm: select ANON_INODES for proxy driver

On Fri, Apr 29, 2016 at 09:42:06PM +0300, Jarkko Sakkinen wrote:
> On Thu, Apr 28, 2016 at 12:46:13PM +0200, Arnd Bergmann wrote:
> > The newly added vtpmx driver fails to build if CONFIG_ANON_INODES
> > is disabled:
> > 
> > drivers/char/built-in.o: In function `vtpmx_fops_ioctl':
> > (.text+0x97f8): undefined reference to `anon_inode_getfile'
> > 
> > This adds a Kconfig 'select' statement to ensure it's always there
> > when we need it.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > Fixes: 794c38e01358 ("tpm: Proxy driver for supporting multiple emulated TPMs")
> 
> Acked-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
> 
> /Jarkko

Applied and merge to next.

/Jarkko

> > ---
> >  drivers/char/tpm/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
> > index 0eac596e33d1..bfdc5c0486aa 100644
> > --- a/drivers/char/tpm/Kconfig
> > +++ b/drivers/char/tpm/Kconfig
> > @@ -125,6 +125,7 @@ config TCG_CRB
> >  config TCG_VTPM_PROXY
> >  	tristate "VTPM Proxy Interface"
> >  	depends on TCG_TPM
> > +	select ANON_INODES
> >  	---help---
> >  	  This driver proxies for an emulated TPM (vTPM) running in userspace.
> >  	  A device /dev/vtpmx is provided that creates a device pair
> > -- 
> > 2.7.0
> >