linux-kernel - Re: [PATCH] batman-adv: Deinline batadv_orig_hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2566792.fAMG9yDVtv@sven-edge>
Date:	Fri, 29 Apr 2016 23:15:34 +0200
From:	Sven Eckelmann <sven@...fation.org>
To:	Denys Vlasenko <dvlasenk@...hat.com>
Cc:	Marek Lindner <mareklindner@...mailbox.ch>,
	Simon Wunderlich <sw@...onwunderlich.de>,
	Antonio Quartulli <a@...table.cc>,
	b.a.t.m.a.n@...ts.open-mesh.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] batman-adv: Deinline batadv_orig_hash_find, save 9024 bytes

On Monday 25 April 2016 15:25:22 Denys Vlasenko wrote:
> This function compiles to 473 bytes of machine code.
> 21 callsites.
> 
>     text     data      bss       dec     hex filename
> 95903266 20860288 35991552 152755106 91adba2 vmlinux_before
> 95894242 20860288 35991552 152746082 91ab862 vmlinux
> 
> Signed-off-by: Denys Vlasenko <dvlasenk@...hat.com>
> CC: Marek Lindner <mareklindner@...mailbox.ch>
> CC: Simon Wunderlich <sw@...onwunderlich.de>
> CC: Antonio Quartulli <a@...table.cc>
> CC: Sven Eckelmann <sven@...fation.org>
> CC: b.a.t.m.a.n@...ts.open-mesh.org
> CC: linux-kernel@...r.kernel.org
> ---
>  net/batman-adv/originator.c | 29 +++++++++++++++++++++++++++++
>  net/batman-adv/originator.h | 31 ++-----------------------------
>  2 files changed, 31 insertions(+), 29 deletions(-)
> 

This patch should also remove following includes from originator.h:

-#include <linux/kref.h>
-#include <linux/rculist.h>
-#include <linux/rcupdate.h>
-#include <linux/stddef.h>
-#include "hash.h"

and add following includes to originator.c (please keep them in alphabetical 
order):

+#include <linux/rcupdate.h>
+#include <linux/stddef.h>

Kind regards,
	Sven
Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)